chore: move abort to last

9romise · 9romise · commit fe877b95605c · 2025-09-23T14:51:54.000+08:00
diff --git a/packages/reactivity/src/effectScope.ts b/packages/reactivity/src/effectScope.ts
@@ -82,9 +82,6 @@ export class EffectScope implements ReactiveNode {
     if (!this.active) {
       return
     }
-    if (this._controller) {
-      this._controller.abort()
-    }
     this.flags = EffectFlags.STOP
     let dep = this.deps
     while (dep !== undefined) {
@@ -101,6 +98,9 @@ export class EffectScope implements ReactiveNode {
       unlink(sub)
     }
     cleanup(this)
+    if (this._controller) {
+      this._controller.abort()
+    }
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -82,9 +82,6 @@ export class EffectScope implements ReactiveNode {`
`82`	`82`	`if (!this.active) {`
`83`	`83`	`return`
`84`	`84`	`}`
`85`		`- if (this._controller) {`
`86`		`- this._controller.abort()`
`87`		`- }`
`88`	`85`	`this.flags = EffectFlags.STOP`
`89`	`86`	`let dep = this.deps`
`90`	`87`	`while (dep !== undefined) {`
`@@ -101,6 +98,9 @@ export class EffectScope implements ReactiveNode {`
`101`	`98`	`unlink(sub)`
`102`	`99`	`}`
`103`	`100`	`cleanup(this)`
	`101`	`+ if (this._controller) {`
	`102`	`+ this._controller.abort()`
	`103`	`+ }`
`104`	`104`	`}`
`105`	`105`	`}`
`106`	`106`