Skip to content

feat: allow string arguments on directives #496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 22, 2021

Conversation

KaelWD
Copy link
Contributor

@KaelWD KaelWD commented Sep 5, 2021

🤔 What is the nature of this change?

  • New feature
  • Fix bug
  • Style optimization
  • Code style optimization
  • Performance optimization
  • Build optimization
  • Refactor code or style
  • Test related
  • Other

🔗 Related Issue

resolves #325

💡 Background or solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@@ -13,7 +13,7 @@ const patchFlagExpect = (
flag: number,
dynamic: string[] | null,
) => {
const { patchFlag, dynamicProps } = wrapper.vm.$.subTree;
const { patchFlag, dynamicProps } = wrapper.vm.$.subTree as any;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was made internal in v3.2.0: vuejs/core@8610e1c

@Amour1688
Copy link
Member

Could you help perfect the document ? Thanks.

@Amour1688 Amour1688 merged commit 1ab8483 into vuejs:dev Sep 22, 2021
@KaelWD KaelWD mentioned this pull request Oct 6, 2021
@KaelWD KaelWD deleted the feat/directive-arguments branch October 6, 2021 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Proposal] namespaced JSX elements and attributes will be available in ts 4.2
2 participants