docs: Essentials > The Application Instance #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for vuejs-v3-ja-doc-preview ready! Built with commit 4012dea https://deploy-preview-56--vuejs-v3-ja-doc-preview.netlify.app |
kazupon
approved these changes
Sep 19, 2020
src/guide/instance.md
Outdated
| └─ TodoListFooter | ||
| ├─ ClearTodosButton | ||
| └─ TodoListStatistics | ||
| ルートインスタンス |
There was a problem hiding this comment.
ここの部分は、コードのロジック上にあるコンポーネントツリーの内容なので、ツリーの各ノードの項目は、訳さない方が読み手がロジックで意識してやすいので、そのままにしておきたいです。
@potato4d
どう思いますか？
There was a problem hiding this comment.
既存のv2ドキュメントのソース参照したときにこう訳してあったので、あれ？と思いつつ準じたのですが、今見たら公開版（vuejs/jp.vuejs.org）はコンポーネント名そのままなのでこちらの取り違えミスでした、すみません！🙇
コメント同意見です、 @potato4d さんから特に異論なければ修正入れて再提出します。ありがとうございます
|
あ、間違って approve してしまった... |
nandenjin
force-pushed
the
issue-4_application-instance
branch
from
66524c0 to
4012dea
Compare
|
@kazupon 修正しました、再レビューお願いします🙏 |
|
@nandenjin ありがとうございます！修正されていること確認しました！マージしますね！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4: Essentials -> The Application Instanceの翻訳