Translate: Migration Guide > KeyCode Modifiers #156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for vuejs-v3-ja-doc-preview ready! Built with commit aa55900 https://deploy-preview-156--vuejs-v3-ja-doc-preview.netlify.app |
potato4d
suggested changes
Nov 3, 2020
|
|
||
| For those using `keyCode` in their codebase, we recommend converting them to their kebab-cased named equivalents. | ||
| キーコードを利用している場合は、ケバブケース名を利用する方法に変更することを推奨します。 |
There was a problem hiding this comment.
Suggested change
| キーコードを利用している場合は、ケバブケース名を利用する方法に変更することを推奨します。 | |
| キーコードを利用している場合は、ケバブケースでの命名に変更することを推奨します。 |
日本語として少し違和感があるので、 naming を 命名 と訳した上で方法というのをそこに含めてしまうほうが読みやすいかなと！
| <input v-on:keyup.f1="showHelpText" /> | ||
| ``` | ||
|
|
||
| ## 3.x Syntax | ||
| ## 3.x 構文 |
There was a problem hiding this comment.
Suggested change
| ## 3.x 構文 | |
| ## 3.x での構文 |
ここ申し訳ないのですが、 での構文 で統一させてほしいです！
|
|
||
| ## 2.x Syntax | ||
| ## 2.x 構文 |
There was a problem hiding this comment.
Suggested change
| ## 2.x 構文 | |
| ## 2.x での構文 |
ここ申し訳ないのですが、 での構文 で統一させてほしいです！
|
レビューありがとうございます！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Problem
resolve #121
Proposed Solution
Additional Information
https://github.com/vuejs-jp/ja.vuejs.org/blob/lang-ja/src/guide/migration/keycode-modifiers.md
こちらの翻訳です
遅くなってすみません。レビューよろしくお願いします！