Translate: Migration Guide > Data Option #147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for vuejs-v3-ja-doc-preview ready! Built with commit cf116b4 https://deploy-preview-147--vuejs-v3-ja-doc-preview.netlify.app |
|
遅くなりました、よろしくお願いします。 |
potato4d
reviewed
Oct 30, 2020
src/guide/migration/data-option.md
Outdated
| @@ -38,13 +37,13 @@ For example: | |||
| </script> | |||
| ``` | |||
|
|
|||
| Though this provided some convenience in terms of root instances having a shared state, this has led to confusion due to the fact that its only possible on the root instance. | |||
| これは共有状態を持っているルートインスタンスに関してはある程度の利便性をもたらしましたが、ルートインスタンスでのみ可能であるという事実のため混乱を招きました。 | |||
There was a problem hiding this comment.
Suggested change
| これは共有状態を持っているルートインスタンスに関してはある程度の利便性をもたらしましたが、ルートインスタンスでのみ可能であるという事実のため混乱を招きました。 | |
| これは共有状態を持っているルートインスタンスに関してはある程度の利便性をもたらしましたが、ルートインスタンスでのみ可能であるという事実のため混乱を招きました。 |
この shared の ed が state にかかっていて、 状態が共有されている と表現できる認識です。いかがでしょう？
potato4d
suggested changes
Nov 1, 2020
src/guide/migration/data-option.md
Outdated
| badges: | ||
| - breaking | ||
| --- | ||
|
|
||
| # {{ $frontmatter.title }} <MigrationBadges :badges="$frontmatter.badges" /> | ||
| # Data オプション <MigrationBadges :badges="$frontmatter.badges" /> |
There was a problem hiding this comment.
こちらなんですが、 frontmatter 側を変更いただきたいですー。
|
@potato4d |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Problem
resolve #112
Proposed Solution
https://github.com/vuejs-jp/ja.vuejs.org/blob/lang-ja/src/guide/migration/data-option.md を翻訳
Additional Information
https://deploy-preview-147--vuejs-v3-ja-doc-preview.netlify.app/guide/migration/data-option.html#%E6%A6%82%E8%A6%81
で確認できます。