Skip to content

The description of this in setup is inconsistent with the source code #368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
naokie opened this issue May 28, 2021 · 2 comments · Fixed by #388
Closed

The description of this in setup is inconsistent with the source code #368

naokie opened this issue May 28, 2021 · 2 comments · Fixed by #388

Comments

@naokie
Copy link
Member

naokie commented May 28, 2021

New updates on head repo.
vuejs/docs@42bb2a2
@kazupon
Copy link
Member

kazupon commented May 28, 2021

chetsumi-next 、バグった？

@naokie
Copy link
Member Author

naokie commented May 29, 2021

oh...

https://github.com/vuejs-jp/che-tsumi-next/blob/42ed6f259582a3bfacbc23e0079a807e6fb14d14/src/chetsumi.ts#L125
Issue 作るときに利用している文字列が、Feed のコンテンツ、つまりコミットメッセージ全文になっちゃってました。

ここは feed.title がよさそう。
vite-docs-ja でも同じ現象起きてましたが、コミットメッセージが短いからか、気づいてなかったですね 😅

@naokie naokie mentioned this issue May 29, 2021
Merged
@naokie naokie changed the title The description of this in setup is inconsistent with the source code * The description of this in setup is inconsistent with the source code * More accurate description of this in the setup function Co-authored-by: skirtle <[email protected]> * fix:Removed some formatted commas Co-authored-by: coderwhy <[email protected]> Co-authored-by: skirtle <[email protected]> The description of this in setup is inconsistent with the source code May 31, 2021
@naokie naokie mentioned this issue Jun 8, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

The description of this in setup is inconsistent with the source code naokie/ja.vuejs.org
2 participants
@naokie @kazupon