Skip to content

Commit 9bebc95

Browse files
authored
[Misc] Deprecate --dataset from benchmark_serving.py (#13708)
Signed-off-by: Roger Wang <[email protected]>
1 parent 5a2ba16 commit 9bebc95

File tree

1 file changed

+4
-19
lines changed

1 file changed

+4
-19
lines changed

benchmarks/benchmark_serving.py

Lines changed: 4 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -867,18 +867,10 @@ def main(args: argparse.Namespace):
867867
tokenizer_mode=tokenizer_mode,
868868
trust_remote_code=args.trust_remote_code)
869869

870-
if args.dataset is not None:
871-
warnings.warn(
872-
"The '--dataset' argument will be deprecated in the next "
873-
"release. Please use '--dataset-name' and "
874-
"'--dataset-path' in the future runs.",
875-
stacklevel=2)
876-
input_requests = sample_sharegpt_requests(
877-
dataset_path=args.dataset,
878-
num_requests=args.num_prompts,
879-
tokenizer=tokenizer,
880-
fixed_output_len=args.sharegpt_output_len,
881-
)
870+
if args.dataset_name is None:
871+
raise ValueError(
872+
"Please specify '--dataset-name' and the corresponding "
873+
"'--dataset-path' if required.")
882874

883875
elif args.dataset_name == "sharegpt":
884876
input_requests = sample_sharegpt_requests(
@@ -1052,13 +1044,6 @@ def main(args: argparse.Namespace):
10521044
default="/v1/completions",
10531045
help="API endpoint.",
10541046
)
1055-
parser.add_argument(
1056-
"--dataset",
1057-
type=str,
1058-
default=None,
1059-
help="Path to the ShareGPT dataset, will be deprecated in the "
1060-
"next release.",
1061-
)
10621047
parser.add_argument(
10631048
"--dataset-name",
10641049
type=str,

0 commit comments

Comments
 (0)