further fix test

luccafong · luccafong · commit 554625d293e4 · 2025-10-13T13:44:40.000-07:00
Signed-off-by: Lu Fang &lt;fanglu@fb.com&gt;
diff --git a/tests/v1/metrics/test_engine_logger_apis.py b/tests/v1/metrics/test_engine_logger_apis.py
@@ -73,9 +73,11 @@ async def test_async_llm_add_to_default_loggers(log_stats_enabled_engine_args):
         disabled_log_engine_args, stat_loggers=[DummyStatLogger]
     )
 
-    assert len(engine.logger_manager.per_engine_logger_dict[0]) == 1
+    assert len(engine.logger_manager.stat_loggers) == 2
+    assert len(engine.logger_manager.stat_loggers[0].per_engine_stat_loggers) == 1
     assert isinstance(
-        engine.logger_manager.per_engine_logger_dict[0][0], DummyStatLogger
+        engine.logger_manager.stat_loggers[0].per_engine_stat_loggers[0],
+        DummyStatLogger,
     )
 
     # log_stats is still True, since custom stat loggers are used

Original file line number	Diff line number	Diff line change
`@@ -73,9 +73,11 @@ async def test_async_llm_add_to_default_loggers(log_stats_enabled_engine_args):`
`73`	`73`	`disabled_log_engine_args, stat_loggers=[DummyStatLogger]`
`74`	`74`	`)`
`75`	`75`
`76`		`- assert len(engine.logger_manager.per_engine_logger_dict[0]) == 1`
	`76`	`+ assert len(engine.logger_manager.stat_loggers) == 2`
	`77`	`+ assert len(engine.logger_manager.stat_loggers[0].per_engine_stat_loggers) == 1`
`77`	`78`	`assert isinstance(`
`78`		`- engine.logger_manager.per_engine_logger_dict[0][0], DummyStatLogger`
	`79`	`+ engine.logger_manager.stat_loggers[0].per_engine_stat_loggers[0],`
	`80`	`+ DummyStatLogger,`
`79`	`81`	`)`
`80`	`82`
`81`	`83`	`# log_stats is still True, since custom stat loggers are used`