Skip to content

Conversation

@ghWass93
Copy link
Contributor

@ghWass93 ghWass93 commented Feb 3, 2022

Summary

Fix github cli "lint issue"
Support Windows environment for testing and formating actions
Enable importHelpers in tsConfig

Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows Conventional Commits standard
  • The code follows project code style standards
  • Tests have been added for this change
  • Docs have been added (if needed)

Type

  • Bugfix
  • Feature
  • Refactor
  • CI
  • Documentation
  • Other... Please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR add new third-party libraries? If yes, please explain why

  • Yes
  • No

By using platform from node process, we can support executing test for Windows host
Single quotes fail in Windows Hosts
The compiler option "importHelpers" should be enabled to reduce the output size.
See more: https://www.typescriptlang.org/tsconfig#importHelpers
@vitorsalgado vitorsalgado merged commit 00058bb into vitorsalgado:main Feb 4, 2022
@vitorsalgado
Copy link
Owner

Nice additions. Thanks for contributing @ghWass93

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants