feat: support rolldown-vite (#7509)

Co-authored-by: Hiroshi Ogawa <[email protected]>

Author: sheremet-va

.github/workflows/ci.yml

@@ -157,3 +157,39 @@ jobs:
 
       - name: Test Browser (webdriverio)
         run: pnpm run test:browser:webdriverio
+
+  test-rolldown:
+    needs: changed
+    # macos-latest is the fastes one
+    name: 'Rolldown&Test: node-20, macos-latest'
+    if: needs.changed.outputs.should_skip != 'true'
+    runs-on: macos-latest
+
+    timeout-minutes: 30
+
+    steps:
+      - uses: actions/checkout@v4
+
+      - uses: ./.github/actions/setup-and-cache
+        with:
+          node-version: 20
+
+      - uses: browser-actions/setup-chrome@c785b87e244131f27c9f19c1a33e2ead956ab7ce # v1.7.3
+
+      - name: Install
+        run: pnpm add vite@npm:rolldown-vite && git add . && git commit -m "ci" && pnpm i --prefer-offline --no-frozen-lockfile
+
+      - name: Install Playwright Dependencies
+        run: pnpm exec playwright install --with-deps --only-shell
+
+      - name: Build
+        run: pnpm run build
+
+      - name: Test
+        run: pnpm run test:ci
+
+      - name: Test Examples
+        run: pnpm run test:examples
+
+      - name: Test Browser (playwright)
+        run: pnpm run test:browser:playwright

package.json

@@ -14,7 +14,7 @@
     "build": "pnpm -r --filter @vitest/ui --filter='./packages/**' run build",
     "dev": "NODE_OPTIONS=\"--max-old-space-size=8192\" pnpm -r --parallel --filter='./packages/**' run dev",
     "docs": "pnpm -C docs run dev",
-    "docs:build": "pnpm -C docs run build",
+    "docs:build": "ROLLDOWN_OPTIONS_VALIDATION=loose pnpm -C docs run build",
     "docs:serve": "pnpm -C docs run serve",
     "docs:https": "pnpm -C docs run preview-https",
     "docs:https-no-prefetch": "pnpm -C docs run preview-https-no-prefetch",
@@ -96,6 +96,7 @@
       "esbuild",
       "geckodriver",
       "msw",
+      "rolldown",
       "sharp",
       "svelte-preprocess",
       "vue-demi"

packages/runner/src/suite.ts

@@ -366,7 +366,7 @@ function createSuiteCollector(
 
     if (runner.config.includeTaskLocation) {
       const error = stackTraceError.stack!
-      const stack = findTestFileStackTrace(error, task.each ?? false)
+      const stack = findTestFileStackTrace(error)
       if (stack) {
         task.location = stack
       }
@@ -460,7 +460,7 @@ function createSuiteCollector(
       Error.stackTraceLimit = 15
       const error = new Error('stacktrace').stack!
       Error.stackTraceLimit = limit
-      const stack = findTestFileStackTrace(error, suite.each ?? false)
+      const stack = findTestFileStackTrace(error)
       if (stack) {
         suite.location = stack
       }
@@ -890,21 +890,16 @@ function formatTemplateString(cases: any[], args: any[]): any[] {
   return res
 }
 
-function findTestFileStackTrace(error: string, each: boolean) {
+function findTestFileStackTrace(error: string) {
+  const testFilePath = getTestFilepath()
   // first line is the error message
   const lines = error.split('\n').slice(1)
   for (const line of lines) {
     const stack = parseSingleStack(line)
-    if (stack && stack.file === getTestFilepath()) {
+    if (stack && stack.file === testFilePath) {
       return {
         line: stack.line,
-        /**
-         * test.each([1, 2])('name')
-         *                 ^ leads here, but should
-         *                  ^ lead here
-         * in source maps it's the same boundary, so it just points to the start of it
-         */
-        column: each ? stack.column + 1 : stack.column,
+        column: stack.column,
       }
     }
   }

packages/vitest/src/node/plugins/normalizeURL.ts

@@ -26,7 +26,7 @@ export function NormalizeURLPlugin(): Plugin {
       const assetImportMetaUrlRE
       // vite injects new URL(path, import.meta.url) in the code
       // rolldown-vite injects new URL(path, '' + import.meta.url) in the code
-          = /\bnew\s+URL\s*\(\s*(?:'[^']+'|"[^"]+"|`[^`]+`)\s*,\s*(?:'' \+ )?import\.meta\.url\s*(?:,\s*)?\)/g
+        = /\bnew\s+URL\s*\(\s*(?:'[^']+'|"[^"]+"|`[^`]+`)\s*,\s*(?:'' \+ )?import\.meta\.url\s*(?:,\s*)?\)/g
 
       let updatedCode = code
       let match: RegExpExecArray | null

packages/vitest/src/public/node.ts

@@ -1,5 +1,5 @@
 import type { ModuleDiagnostic as _FileDiagnostic } from '../node/reporters/reported-tasks'
-import { createServer as _createServer } from 'vite'
+import * as vite from 'vite'
 import { Vitest } from '../node/core'
 import { TestModule as _TestFile } from '../node/reporters/reported-tasks'
 
@@ -81,8 +81,8 @@ export type {
   ResolvedBrowserOptions,
 } from '../node/types/browser'
 /** @deprecated use `createViteServer` instead */
-export const createServer: typeof _createServer = _createServer
-export const createViteServer: typeof _createServer = _createServer
+export const createServer: typeof vite.createServer = vite.createServer
+export const createViteServer: typeof vite.createServer = vite.createServer
 export type {
   ApiConfig,
   BuiltinEnvironment,
@@ -175,4 +175,7 @@ export {
   version as viteVersion,
 } from 'vite'
 
+// rolldownVersion is exported only by rolldown-vite
+export const rolldownVersion: string | undefined = (vite as any).rolldownVersion
+
 export type * as Vite from 'vite'