Don't register invalid server action exports

Author: unstubbable

crates/next-custom-transforms/src/transforms/server_actions.rs

@@ -1126,6 +1126,15 @@ impl<C: Comments> VisitMut for ServerActions<C> {
                 .cloned();
 
             if !self.validate_async_function(f.is_async, f.span, fn_name.as_ref(), &directive) {
+                // If this is an exported function that failed validation, remove it from
+                // export_name_by_local_id so the post-pass doesn't register it.
+                if self.current_export_name.is_some() {
+                    if let Some(ref invalid_fn_name) = fn_name {
+                        self.export_name_by_local_id
+                            .swap_remove(&invalid_fn_name.to_id());
+                    }
+                }
+
                 return;
             }
 
@@ -1336,6 +1345,15 @@ impl<C: Comments> VisitMut for ServerActions<C> {
                 self.arrow_or_fn_expr_ident.as_ref(),
                 &directive,
             ) {
+                // If this is an exported arrow function that failed validation, remove it from
+                // export_name_by_local_id so the post-pass doesn't register it.
+                if self.current_export_name.is_some() {
+                    if let Some(ref arrow_ident) = self.arrow_or_fn_expr_ident {
+                        self.export_name_by_local_id
+                            .swap_remove(&arrow_ident.to_id());
+                    }
+                }
+
                 return;
             }
 

crates/next-custom-transforms/tests/errors/server-actions/server-graph/1/output.js

@@ -1,7 +1 @@
-/* __next_internal_action_entry_do_not_use__ {"7fab21efdafbe611287bc25c0462b1e0510d13e48b":"foo"} */ import { registerServerReference } from "private-next-rsc-server-reference";
 export function foo() {}
-import { ensureServerEntryExports } from "private-next-rsc-action-validate";
-ensureServerEntryExports([
-    foo
-]);
-registerServerReference(foo, "7fab21efdafbe611287bc25c0462b1e0510d13e48b", null);

crates/next-custom-transforms/tests/errors/server-actions/server-graph/2/output.js

@@ -1,8 +1,2 @@
-/* __next_internal_action_entry_do_not_use__ {"7fac840dcaf5e8197cb02b7f3a43c119b7a770b272":"bar"} */ import { registerServerReference } from "private-next-rsc-server-reference";
 'use strict';
 export function bar() {}
-import { ensureServerEntryExports } from "private-next-rsc-action-validate";
-ensureServerEntryExports([
-    bar
-]);
-registerServerReference(bar, "7fac840dcaf5e8197cb02b7f3a43c119b7a770b272", null);