Remove experimental.reactOwnerStack

Author: eps1lon

packages/next/src/build/webpack/plugins/define-env-plugin.ts

@@ -293,8 +293,6 @@ export function getDefineEnv({
       : undefined),
     'process.env.__NEXT_EXPERIMENTAL_NEW_DEV_OVERLAY':
       config.experimental.newDevOverlay || false,
-    'process.env.__NEXT_REACT_OWNER_STACK':
-      config.experimental.reactOwnerStack ?? false,
   }
 
   const userDefines = config.compiler?.define ?? {}

packages/next/src/client/components/errors/stitched-error.ts

@@ -8,9 +8,6 @@ const REACT_ERROR_STACK_BOTTOM_FRAME_REGEX = new RegExp(
 )
 
 export function getReactStitchedError<T = unknown>(err: T): Error | T {
-  if (!process.env.__NEXT_REACT_OWNER_STACK) {
-    return err
-  }
   const isErrorInstance = isError(err)
   const originStack = isErrorInstance ? err.stack || '' : ''
   const originMessage = isErrorInstance ? err.message : ''

packages/next/src/lib/needs-experimental-react.ts

@@ -1,7 +1,6 @@
 import type { NextConfig } from '../server/config-shared'
 
 export function needsExperimentalReact(config: NextConfig) {
-  const { ppr, taint, reactOwnerStack, viewTransition } =
-    config.experimental || {}
-  return Boolean(ppr || taint || reactOwnerStack || viewTransition)
+  const { ppr, taint, viewTransition } = config.experimental || {}
+  return Boolean(ppr || taint || viewTransition)
 }

packages/next/src/server/config-schema.ts

@@ -333,7 +333,6 @@ export const configSchema: zod.ZodType<NextConfig> = z.lazy(() =>
           .readonly()
           .optional(),
         taint: z.boolean().optional(),
-        reactOwnerStack: z.boolean().optional(),
         prerenderEarlyExit: z.boolean().optional(),
         proxyTimeout: z.number().gte(0).optional(),
         scrollRestoration: z.boolean().optional(),

packages/next/src/server/config-shared.ts

@@ -472,12 +472,6 @@ export interface ExperimentalConfig {
    */
   taint?: boolean
 
-  /**
-   * Enables leveraging experimental captureOwnerStack API in React,
-   * to create a better stack trace for React errors.
-   */
-  reactOwnerStack?: boolean
-
   serverActions?: {
     /**
      * Allows adjusting body parser size limit for server actions.
@@ -1235,7 +1229,6 @@ export const defaultConfig: NextConfig = {
         process.env.__NEXT_EXPERIMENTAL_PPR === 'true'
       ),
     authInterrupts: false,
-    reactOwnerStack: false,
     webpackBuildWorker: undefined,
     webpackMemoryOptimizations: false,
     optimizeServerReact: true,

packages/next/src/server/config.ts

@@ -921,14 +921,9 @@ function assignDefaults(
   }
 
   // TODO(jiwon): remove once we've made new UI default
-  // Enable reactOwnerStack when newDevOverlay is enabled to have
-  // better call stack output in the new UI.
   if (process.env.__NEXT_EXPERIMENTAL_NEW_DEV_OVERLAY === 'false') {
     result.experimental.newDevOverlay = false
   }
-  if (result.experimental.newDevOverlay) {
-    result.experimental.reactOwnerStack = true
-  }
 
   result.experimental.optimizePackageImports = [
     ...new Set([

test/development/acceptance-app/hydration-error.test.ts

@@ -5,12 +5,6 @@ import path from 'path'
 import { outdent } from 'outdent'
 import { getRedboxTotalErrorCount, retry } from 'next-test-utils'
 
-// https://github.com/facebook/react/blob/main/packages/react-dom/src/__tests__/ReactDOMHydrationDiff-test.js used as a reference
-
-const enableOwnerStacks =
-  process.env.__NEXT_EXPERIMENTAL_NEW_DEV_OVERLAY === 'true' ||
-  process.env.__NEXT_EXPERIMENTAL_PPR === 'true'
-
 describe('Error overlay for hydration errors in App router', () => {
   const { next, isTurbopack } = nextTestSetup({
     files: new FileRef(path.join(__dirname, 'fixtures', 'default-template')),
@@ -800,10 +794,7 @@ describe('Error overlay for hydration errors in App router', () => {
     await session.openRedbox()
 
     await retry(async () => {
-      expect(await getRedboxTotalErrorCount(browser)).toBe(
-        // With owner stacks, we also get an error for the parent context
-        enableOwnerStacks ? 3 : 2
-      )
+      expect(await getRedboxTotalErrorCount(browser)).toBe(3)
     })
 
     const description = await session.getRedboxDescription()
@@ -874,10 +865,7 @@ describe('Error overlay for hydration errors in App router', () => {
     await retry(async () => {
       expect(await getRedboxTotalErrorCount(browser)).toBe(
         // One error for "Cannot render a sync or defer <script>"
-        enableOwnerStacks
-          ? // With owner stacks, we also get an error for the parent context.
-            3
-          : 2
+        3
       )
     })