Skip to content

Commit 0469aec

Browse files
authored
Revert "Turbopack: JsAnalyzer parse AssignExpr (#83962)" (#86420)
This reverts commit 2d80f1a. <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # -->
1 parent bb65e78 commit 0469aec

File tree

9 files changed

+10708
-11135
lines changed

9 files changed

+10708
-11135
lines changed

turbopack/crates/turbopack-ecmascript/src/analyzer/graph.rs

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -800,8 +800,10 @@ impl EvalContext {
800800
..
801801
}) => JsValue::WellKnownObject(WellKnownObjectKind::ImportMeta),
802802

803-
Expr::Assign(AssignExpr { op, right, .. }) => match op {
804-
AssignOp::Assign => self.eval(right),
803+
Expr::Assign(AssignExpr { op, .. }) => match op {
804+
// TODO: `self.eval(right)` would be the value, but we need to handle the side
805+
// effect of that expression
806+
AssignOp::Assign => JsValue::unknown_empty(true, "assignment expression"),
805807
_ => JsValue::unknown_empty(true, "compound assignment expression"),
806808
},
807809

0 commit comments

Comments
 (0)