[test] Run all dev tests with sourcemaps enabled (#83173)

eps1lon · web-flow · commit 00261e9154c0 · 2025-08-29T10:18:11.000+02:00
diff --git a/packages/next/src/build/webpack/config/blocks/base.ts b/packages/next/src/build/webpack/config/blocks/base.ts
@@ -35,15 +35,11 @@ export const base = curry(function base(
 
   // https://webpack.js.org/configuration/devtool/#development
   if (ctx.isDevelopment) {
-    if (process.env.__NEXT_TEST_MODE && !process.env.__NEXT_TEST_WITH_DEVTOOL) {
-      config.devtool = false
-    } else {
-      // `eval-source-map` provides full-fidelity source maps for the
-      // original source, including columns and original variable names.
-      // This is desirable so the in-browser debugger can correctly pause
-      // and show scoped variables with their original names.
-      config.devtool = 'eval-source-map'
-    }
+    // `eval-source-map` provides full-fidelity source maps for the
+    // original source, including columns and original variable names.
+    // This is desirable so the in-browser debugger can correctly pause
+    // and show scoped variables with their original names.
+    config.devtool = 'eval-source-map'
   } else {
     if (
       ctx.isEdgeRuntime ||
diff --git a/test/development/middleware-errors/index.test.ts b/test/development/middleware-errors/index.test.ts
@@ -5,7 +5,6 @@ import { nextTestSetup } from 'e2e-utils'
 describe('middleware - development errors', () => {
   const { next, isTurbopack } = nextTestSetup({
     files: __dirname,
-    env: { __NEXT_TEST_WITH_DEVTOOL: '1' },
     patchFileDelay: 500,
   })
   beforeEach(async () => {
diff --git a/test/integration/client-navigation-a11y/test/index.test.js b/test/integration/client-navigation-a11y/test/index.test.js
@@ -29,9 +29,7 @@ const getMainHeadingTitle = async (browser) =>
 describe('Client Navigation accessibility', () => {
   beforeAll(async () => {
     context.appPort = await findPort()
-    context.server = await launchApp(appDir, context.appPort, {
-      env: { __NEXT_TEST_WITH_DEVTOOL: 1 },
-    })
+    context.server = await launchApp(appDir, context.appPort)
 
     const prerender = [
       '/page-with-h1-and-title, /page-with-h1, /page-with-title, /page-without-h1-or-title',
diff --git a/test/integration/config-devtool-dev/test/index.test.js b/test/integration/config-devtool-dev/test/index.test.js
@@ -22,7 +22,6 @@ const appDir = join(__dirname, '../')
 
       const appPort = await findPort()
       const app = await launchApp(appDir, appPort, {
-        env: { __NEXT_TEST_WITH_DEVTOOL: true },
         onStderr(msg) {
           stderr += msg || ''
         },
diff --git a/test/integration/edge-runtime-configurable-guards/test/index.test.js b/test/integration/edge-runtime-configurable-guards/test/index.test.js
@@ -30,7 +30,6 @@ const context = {
   ),
 }
 const appOption = {
-  env: { __NEXT_TEST_WITH_DEVTOOL: 1 },
   onStdout(msg) {
     context.logs.output += msg
     context.logs.stdout += msg
diff --git a/test/integration/edge-runtime-dynamic-code/test/index.test.js b/test/integration/edge-runtime-dynamic-code/test/index.test.js
@@ -30,7 +30,6 @@ describe('Page using eval in development mode', () => {
   beforeAll(async () => {
     context.appPort = await findPort()
     context.app = await launchApp(context.appDir, context.appPort, {
-      env: { __NEXT_TEST_WITH_DEVTOOL: 1 },
       onStdout(msg) {
         output += msg
       },
@@ -84,7 +83,6 @@ describe.each([
         beforeAll(async () => {
           context.appPort = await findPort()
           context.app = await launchApp(context.appDir, context.appPort, {
-            env: { __NEXT_TEST_WITH_DEVTOOL: 1 },
             onStdout(msg) {
               output += msg
             },
diff --git a/test/integration/edge-runtime-module-errors/test/utils.js b/test/integration/edge-runtime-module-errors/test/utils.js
@@ -11,7 +11,6 @@ export const context = {
   page: new File(join(__dirname, '../pages/index.js')),
 }
 export const appOption = {
-  env: { __NEXT_TEST_WITH_DEVTOOL: 1 },
   onStdout(msg) {
     context.logs.output += msg
     context.logs.stdout += msg
diff --git a/test/integration/edge-runtime-response-error/test/index.test.js b/test/integration/edge-runtime-response-error/test/index.test.js
@@ -24,7 +24,6 @@ const context = {
   page: new File(join(__dirname, '../pages/index.js')),
 }
 const appOption = {
-  env: { __NEXT_TEST_WITH_DEVTOOL: 1 },
   onStdout(msg) {
     context.logs.output += msg
     context.logs.stdout += msg
diff --git a/test/integration/edge-runtime-streaming-error/test/index.test.ts b/test/integration/edge-runtime-streaming-error/test/index.test.ts
@@ -57,7 +57,6 @@ describe('development mode', () => {
     context.appPort = await findPort()
     context.app = await launchApp(appDir, context.appPort, {
       ...context.handler,
-      env: { __NEXT_TEST_WITH_DEVTOOL: '1' },
     })
   })
 
diff --git a/test/integration/edge-runtime-with-node.js-apis/test/index.test.ts b/test/integration/edge-runtime-with-node.js-apis/test/index.test.ts
@@ -73,7 +73,6 @@ describe.each([
       beforeAll(async () => {
         appPort = await findPort()
         app = await launchApp(appDir, appPort, {
-          env: { __NEXT_TEST_WITH_DEVTOOL: '1' },
           onStdout(msg) {
             output += msg
           },
diff --git a/test/integration/gssp-redirect-with-rewrites/test/index.test.js b/test/integration/gssp-redirect-with-rewrites/test/index.test.js
@@ -17,9 +17,7 @@ const context = {}
 describe('getServerSideProps redirects', () => {
   beforeAll(async () => {
     context.appPort = await findPort()
-    context.server = await launchApp(join(__dirname, '../'), context.appPort, {
-      env: { __NEXT_TEST_WITH_DEVTOOL: 1 },
-    })
+    context.server = await launchApp(join(__dirname, '../'), context.appPort)
 
     // pre-build all pages at the start
     await Promise.all([
diff --git a/test/integration/prerender/test/index.test.js b/test/integration/prerender/test/index.test.js
@@ -25,9 +25,7 @@ describe('SSG Prerender', () => {
       )
       await fs.remove(join(appDir, '.next'))
       appPort = await findPort()
-      app = await launchApp(appDir, appPort, {
-        env: { __NEXT_TEST_WITH_DEVTOOL: 1 },
-      })
+      app = await launchApp(appDir, appPort)
     })
     afterAll(async () => {
       try {
diff --git a/test/integration/server-side-dev-errors/test/index.test.js b/test/integration/server-side-dev-errors/test/index.test.js
@@ -38,9 +38,6 @@ describe('server-side dev errors', () => {
           ''
         )
       },
-      env: {
-        __NEXT_TEST_WITH_DEVTOOL: 1,
-      },
     })
   })
   afterAll(() => killApp(app))
diff --git a/test/integration/typescript-hmr/test/index.test.js b/test/integration/typescript-hmr/test/index.test.js
@@ -21,7 +21,6 @@ describe('TypeScript HMR', () => {
     appPort = await findPort()
     app = await launchApp(appDir, appPort, {
       env: {
-        __NEXT_TEST_WITH_DEVTOOL: 1,
         // Events can be finicky in CI. This switches to a more reliable
         // polling method.
         CHOKIDAR_USEPOLLING: 'true',
diff --git a/test/lib/next-modes/next-dev.ts b/test/lib/next-modes/next-dev.ts
@@ -63,7 +63,6 @@ export class NextDevInstance extends NextInstance {
             NODE_ENV: this.env.NODE_ENV || ('' as any),
             PORT: this.forcedPort || '0',
             __NEXT_TEST_MODE: 'e2e',
-            __NEXT_TEST_WITH_DEVTOOL: '1',
           },
         })
 

Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,6 @@ const context = {`
`30`	`30`	`),`
`31`	`31`	`}`
`32`	`32`	`const appOption = {`
`33`		`- env: { __NEXT_TEST_WITH_DEVTOOL: 1 },`
`34`	`33`	`onStdout(msg) {`
`35`	`34`	`context.logs.output += msg`
`36`	`35`	`context.logs.stdout += msg`
Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,6 @@ export const context = {`
`11`	`11`	`page: new File(join(__dirname, '../pages/index.js')),`
`12`	`12`	`}`
`13`	`13`	`export const appOption = {`
`14`		`- env: { __NEXT_TEST_WITH_DEVTOOL: 1 },`
`15`	`14`	`onStdout(msg) {`
`16`	`15`	`context.logs.output += msg`
`17`	`16`	`context.logs.stdout += msg`
Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,6 @@ const context = {`
`24`	`24`	`page: new File(join(__dirname, '../pages/index.js')),`
`25`	`25`	`}`
`26`	`26`	`const appOption = {`
`27`		`- env: { __NEXT_TEST_WITH_DEVTOOL: 1 },`
`28`	`27`	`onStdout(msg) {`
`29`	`28`	`context.logs.output += msg`
`30`	`29`	`context.logs.stdout += msg`