Skip to content

Commit 884a70b

Browse files
prontclaude
authored andcommitted
fix(blackhole sink): disable rate limiting for periodic stats messages (#24190)
* fix(blackhole sink): disable rate limiting for periodic stats messages The blackhole sink's informational "Collected events" messages were being rate-limited since rate limiting was enabled by default in #24024. This is undesirable because: 1. These are deliberately scheduled periodic messages (controlled by the `print_interval_secs` config option), not error conditions that could flood the logs 2. Users explicitly configure the frequency - rate limiting defeats that explicit configuration and breaks user expectations 3. The interval timer already prevents log flooding, making additional rate limiting redundant 4. The blackhole sink is used for debugging/testing, where predictable output is essential This fix adds `internal_log_rate_limit = false` to both info! calls, similar to how the console sink disables rate limiting for its critical operational messages. Fixes #24188 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]> * chore: add changelog fragment for blackhole sink rate limiting fix --------- Co-authored-by: Claude <[email protected]>
1 parent a011c1e commit 884a70b

File tree

2 files changed

+5
-0
lines changed

2 files changed

+5
-0
lines changed
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
The `blackhole` sink's periodic statistics messages (controlled by `print_interval_secs`) are no longer incorrectly suppressed by rate limiting. These informational messages now appear at the user-configured interval as expected.
2+
3+
authors: pront

src/sinks/blackhole/sink.rs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,7 @@ impl StreamSink<EventArray> for BlackholeSink {
6565
info!(
6666
events = total_events.load(Ordering::Relaxed),
6767
raw_bytes_collected = total_raw_bytes.load(Ordering::Relaxed),
68+
internal_log_rate_limit = false,
6869
"Collected events."
6970
);
7071
},
@@ -75,6 +76,7 @@ impl StreamSink<EventArray> for BlackholeSink {
7576
info!(
7677
events = total_events.load(Ordering::Relaxed),
7778
raw_bytes_collected = total_raw_bytes.load(Ordering::Relaxed),
79+
internal_log_rate_limit = false,
7880
"Collected events."
7981
);
8082
});

0 commit comments

Comments
 (0)