Commit 74f244c
Release Manager
sagemathgh-38005: Fix Help menu breakdown in external jupyterlab case
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->
sagemath#37878 introduced a local documentation server for jupyterlab. But it
missed a case for which the Help menu of jupyterlab may break down.
In the setup explained in
https://doc.sagemath.org/html/en/installation/launching.html#setting-up-
sagemath-as-a-jupyter-kernel-in-an-existing-jupyter-notebook-or-
jupyterlab-installation, external jupyterlab is launched and connected
to sage kernel. In this case, the local doc server does not run, but the
Help menu of the jupyterlab still expects a local doc server, and thus
the Help menu does not work well.
In this PR, local doc server is detected by testing the port number, and
the Help menu uses the online official documentation if local doc server
is not running.
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. -->
- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.
### ⌛ Dependencies
<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
URL: sagemath#38005
Reported by: Kwankyu Lee
Reviewer(s):
1 file changed
+2
-3
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
108 | 108 | | |
109 | 109 | | |
110 | 110 | | |
| 111 | + | |
111 | 112 | | |
112 | 113 | | |
113 | 114 | | |
114 | 115 | | |
115 | 116 | | |
116 | | - | |
117 | | - | |
118 | | - | |
| 117 | + | |
119 | 118 | | |
120 | 119 | | |
121 | 120 | | |
| |||
0 commit comments