feat(dialect): return default on update/delete when create table

Close #1212

Author: j2gg0s

dialect/feature/feature.go

@@ -41,6 +41,7 @@ const (
 	DeleteOrderLimit // DELETE ... ORDER BY ... LIMIT ...
 	DeleteReturning
 	AlterColumnExists // ADD/DROP COLUMN IF NOT EXISTS/IF EXISTS
+	FKDefaultOnAction // FK ON UPDATE/ON DELETE has default value: NO ACTION
 )
 
 type NotSupportError struct {
@@ -91,4 +92,5 @@ var flag2str = map[Feature]string{
 	DeleteOrderLimit:     "DeleteOrderLimit",
 	DeleteReturning:      "DeleteReturning",
 	AlterColumnExists:    "AlterColumnExists",
+	FKDefaultOnAction:    "FKDefaultOnAction",
 }

dialect/mssqldialect/dialect.go

@@ -49,6 +49,7 @@ func New(opts ...DialectOption) *Dialect {
 		feature.Identity |
 		feature.Output |
 		feature.OffsetFetch |
+		feature.FKDefaultOnAction |
 		feature.UpdateFromTable |
 		feature.MSSavepoint
 
@@ -158,15 +159,15 @@ func (d *Dialect) AppendString(b []byte, s string) []byte {
 	return d.BaseDialect.AppendString(b, s)
 }
 
-func (d *Dialect) DefaultVarcharLen() int {
-	return 255
-}
-
 func (d *Dialect) AppendSequence(b []byte, _ *schema.Table, _ *schema.Field) []byte {
 	return append(b, " IDENTITY"...)
 }
 
-func (d *Dialect) DefaultSchema() string {
+func (*Dialect) DefaultVarcharLen() int {
+	return 255
+}
+
+func (*Dialect) DefaultSchema() string {
 	return "dbo"
 }
 

dialect/mysqldialect/dialect.go

@@ -48,6 +48,7 @@ func New(opts ...DialectOption) *Dialect {
 		feature.InsertOnDuplicateKey |
 		feature.SelectExists |
 		feature.CompositeIn |
+		feature.FKDefaultOnAction |
 		feature.UpdateOrderLimit |
 		feature.DeleteOrderLimit
 

dialect/pgdialect/dialect.go

@@ -55,6 +55,7 @@ func New(opts ...DialectOption) *Dialect {
 		feature.SelectExists |
 		feature.GeneratedIdentity |
 		feature.CompositeIn |
+		feature.FKDefaultOnAction |
 		feature.DeleteReturning |
 		feature.AlterColumnExists
 

dialect/sqlitedialect/dialect.go

@@ -41,6 +41,7 @@ func New(opts ...DialectOption) *Dialect {
 		feature.SelectExists |
 		feature.AutoIncrement |
 		feature.CompositeIn |
+		feature.FKDefaultOnAction |
 		feature.DeleteReturning
 
 	for _, opt := range opts {
@@ -102,7 +103,7 @@ func (d *Dialect) AppendBytes(b []byte, bs []byte) []byte {
 	return b
 }
 
-func (d *Dialect) DefaultVarcharLen() int {
+func (*Dialect) DefaultVarcharLen() int {
 	return 0
 }
 
@@ -132,7 +133,7 @@ func (d *Dialect) AppendSequence(b []byte, table *schema.Table, field *schema.Fi
 // DefaultSchemaName is the "schema-name" of the main database.
 // The details might differ from other dialects, but for all means and purposes
 // "main" is the default schema in an SQLite database.
-func (d *Dialect) DefaultSchema() string {
+func (*Dialect) DefaultSchema() string {
 	return "main"
 }
 

query_table_create.go

@@ -318,15 +318,23 @@ func (q *CreateTableQuery) appendFKConstraintsRel(fmter schema.Formatter, b []by
 
 	for _, key := range keys {
 		if rel := relations[key]; rel.References() {
+			query := "(?) REFERENCES ? (?)"
+			args := []any{
+				Safe(appendColumns(nil, "", rel.BasePKs)),
+				rel.JoinTable.SQLName,
+				Safe(appendColumns(nil, "", rel.JoinPKs)),
+			}
+			if len(rel.OnUpdate) > 0 {
+				query += " ?"
+				args = append(args, Safe(rel.OnUpdate))
+			}
+			if len(rel.OnDelete) > 0 {
+				query += " ?"
+				args = append(args, Safe(rel.OnDelete))
+			}
 			b, err = q.appendFK(fmter, b, schema.QueryWithArgs{
-				Query: "(?) REFERENCES ? (?) ? ?",
-				Args: []interface{}{
-					Safe(appendColumns(nil, "", rel.BasePKs)),
-					rel.JoinTable.SQLName,
-					Safe(appendColumns(nil, "", rel.JoinPKs)),
-					Safe(rel.OnUpdate),
-					Safe(rel.OnDelete),
-				},
+				Query: query,
+				Args:  args,
 			})
 			if err != nil {
 				return nil, err

schema/table.go

@@ -11,6 +11,7 @@ import (
 
 	"github.com/jinzhu/inflection"
 
+	"github.com/uptrace/bun/dialect/feature"
 	"github.com/uptrace/bun/internal"
 	"github.com/uptrace/bun/internal/tagparser"
 )
@@ -623,7 +624,10 @@ func (t *Table) belongsToRelation(field *Field) *Relation {
 		rel.Condition = field.Tag.Options["join_on"]
 	}
 
-	rel.OnUpdate = "ON UPDATE NO ACTION"
+	if t.dialect.Features().Has(feature.FKDefaultOnAction) {
+		rel.OnUpdate = "ON UPDATE NO ACTION"
+		rel.OnDelete = "ON DELETE NO ACTION"
+	}
 	if onUpdate, ok := field.Tag.Options["on_update"]; ok {
 		if len(onUpdate) > 1 {
 			panic(fmt.Errorf("bun: %s belongs-to %s: on_update option must be a single field", t.TypeName, field.GoName))
@@ -638,7 +642,6 @@ func (t *Table) belongsToRelation(field *Field) *Relation {
 		rel.OnUpdate = s
 	}
 
-	rel.OnDelete = "ON DELETE NO ACTION"
 	if onDelete, ok := field.Tag.Options["on_delete"]; ok {
 		if len(onDelete) > 1 {
 			panic(fmt.Errorf("bun: %s belongs-to %s: on_delete option must be a single field", t.TypeName, field.GoName))