fix: fmt and tests

Author: CahidArda

upstash_workflow/asyncio/serve/serve.py

@@ -70,7 +70,11 @@ def _serve_base(
 
     async def _handler(request: TRequest) -> TResponse:
         workflow_url, workflow_failure_url = _determine_urls(
-            cast(_AsyncRequest, request), url, base_url, failure_function, failure_url
+            cast(_AsyncRequest, request),
+            url,
+            base_url,
+            False if failure_function is None else True,
+            failure_url,
         )
 
         request_payload = await _get_payload(request) or ""

upstash_workflow/asyncio/workflow_parser.py

@@ -84,7 +84,8 @@ async def _handle_failure(
 
         # Attempt running route_function until the first step
         auth_check = await _DisabledWorkflowContext[Any].try_authentication(
-            route_function, cast(AsyncWorkflowContext[TInitialPayload], workflow_context)
+            route_function,
+            cast(AsyncWorkflowContext[TInitialPayload], workflow_context),
         )
 
         if auth_check == "run-ended":

upstash_workflow/context/auto_executor.py

@@ -77,6 +77,7 @@ def submit_steps_to_qstash(
                 self.context.retries,
                 lazy_step.retries if isinstance(lazy_step, _LazyCallStep) else None,
                 lazy_step.timeout if isinstance(lazy_step, _LazyCallStep) else None,
+                workflow_failure_url=self.context.failure_url,
             ).headers
 
             will_wait = (

upstash_workflow/serve/options.py

@@ -21,7 +21,6 @@
     _FinishCondition,
 )
 from upstash_workflow import WorkflowContext
-from upstash_workflow import AsyncWorkflowContext
 from dataclasses import dataclass
 
 _logger = logging.getLogger(__name__)
@@ -156,12 +155,7 @@ def _determine_urls(
     request: Union[_SyncRequest, _AsyncRequest],
     url: Optional[str],
     base_url: Optional[str],
-    failure_function: Optional[
-        Callable[
-            [Union[WorkflowContext[TInitialPayload], AsyncWorkflowContext[TInitialPayload]], int, str, Dict[str, str]],
-            Any,
-        ]
-    ],
+    failure_function_exists: bool,
     failure_url: Optional[str],
 ) -> Tuple[str, str | None]:
     initial_workflow_url = str(url if url is not None else request.url)
@@ -178,7 +172,7 @@ def replace_base(match: Match[str]) -> str:
     else:
         workflow_url = initial_workflow_url
 
-    workflow_failure_url = workflow_url if failure_function else failure_url
+    workflow_failure_url = workflow_url if failure_function_exists else failure_url
     return cast(Tuple[str, str | None], [workflow_url, workflow_failure_url])
 
 

upstash_workflow/serve/serve.py

@@ -80,7 +80,11 @@ def _handler(request: TRequest) -> TResponse:
         :return: A response.
         """
         workflow_url, workflow_failure_url = _determine_urls(
-            cast(_SyncRequest, request), url, base_url, failure_function, failure_url
+            cast(_SyncRequest, request),
+            url,
+            base_url,
+            False if failure_function is None else True,
+            failure_url,
         )
 
         request_payload = _get_payload(request) or ""

upstash_workflow/workflow_parser.py

@@ -1,5 +1,16 @@
 import json
-from typing import Optional, List, Tuple, Union, Callable, Dict, Any, Literal, TypeVar, cast
+from typing import (
+    Optional,
+    List,
+    Tuple,
+    Union,
+    Callable,
+    Dict,
+    Any,
+    Literal,
+    TypeVar,
+    cast,
+)
 from upstash_workflow.utils import _nanoid, _decode_base64
 from upstash_workflow.constants import (
     WORKFLOW_PROTOCOL_VERSION,