V17 - Removed obsoleted code from Umbraco.Examine (#19966)

Removing obsoleted code from BackOfficeExamineSearcher.cs and dependencies

Author: NillasKA

src/Umbraco.Examine.Lucene/BackOfficeExamineSearcher.cs

@@ -48,70 +48,6 @@ public BackOfficeExamineSearcher(
         _appCaches = appCaches;
     }
 
-    [Obsolete("Please use the non-obsolete constructor. Will be removed in V18.")]
-    public BackOfficeExamineSearcher(
-        IExamineManager examineManager,
-        ILocalizationService languageService,
-        IBackOfficeSecurityAccessor backOfficeSecurityAccessor,
-        IEntityService entityService,
-        IUmbracoTreeSearcherFields treeSearcherFields,
-        AppCaches appCaches,
-        IUmbracoMapper umbracoMapper,
-        IPublishedUrlProvider publishedUrlProvider)
-        : this(
-            examineManager,
-            StaticServiceProvider.Instance.GetRequiredService<ILanguageService>(),
-            backOfficeSecurityAccessor,
-            entityService,
-            treeSearcherFields,
-            appCaches)
-    {
-    }
-
-    [Obsolete("Please use the non-obsolete constructor. Will be removed in V18.")]
-    public BackOfficeExamineSearcher(
-        IExamineManager examineManager,
-        ILocalizationService localizationService,
-        ILanguageService languageService,
-        IBackOfficeSecurityAccessor backOfficeSecurityAccessor,
-        IEntityService entityService,
-        IUmbracoTreeSearcherFields treeSearcherFields,
-        AppCaches appCaches,
-        IUmbracoMapper umbracoMapper,
-        IPublishedUrlProvider publishedUrlProvider)
-        : this(
-            examineManager,
-            languageService,
-            backOfficeSecurityAccessor,
-            entityService,
-            treeSearcherFields,
-            appCaches)
-    {
-    }
-
-    [Obsolete("Please use the method that accepts all parameters. Will be removed in V17.")]
-    public IEnumerable<ISearchResult> Search(
-        string query,
-        UmbracoEntityTypes entityType,
-        int pageSize,
-        long pageIndex,
-        out long totalFound,
-        string? searchFrom = null,
-        bool ignoreUserStartNodes = false)
-        => Search(query, entityType, pageSize, pageIndex, out totalFound, null, null, searchFrom, ignoreUserStartNodes);
-
-    [Obsolete("Please use the method that accepts all parameters. Will be removed in V17.")]
-    public IEnumerable<ISearchResult> Search(
-        string query,
-        UmbracoEntityTypes entityType,
-        int pageSize,
-        long pageIndex,
-        out long totalFound,
-        string[]? contentTypeAliases,
-        string? searchFrom = null,
-        bool ignoreUserStartNodes = false)
-        => Search(query, entityType, pageSize, pageIndex, out totalFound, contentTypeAliases, null, searchFrom, ignoreUserStartNodes);
-
     public IEnumerable<ISearchResult> Search(
         string query,
         UmbracoEntityTypes entityType,

src/Umbraco.Infrastructure/Examine/IBackOfficeExamineSearcher.cs

@@ -8,28 +8,6 @@ namespace Umbraco.Cms.Infrastructure.Examine;
 /// </summary>
 public interface IBackOfficeExamineSearcher
 {
-    [Obsolete("Please use the method that accepts all parameters. Will be removed in V17.")]
-    IEnumerable<ISearchResult> Search(
-        string query,
-        UmbracoEntityTypes entityType,
-        int pageSize,
-        long pageIndex,
-        out long totalFound,
-        string? searchFrom = null,
-        bool ignoreUserStartNodes = false);
-
-    [Obsolete("Please use the method that accepts all parameters. Will be removed in V17.")]
-    IEnumerable<ISearchResult> Search(
-        string query,
-        UmbracoEntityTypes entityType,
-        int pageSize,
-        long pageIndex,
-        out long totalFound,
-        string[]? contentTypeAliases,
-        string? searchFrom = null,
-        bool ignoreUserStartNodes = false)
-        => Search(query, entityType, pageSize, pageIndex, out totalFound, searchFrom, ignoreUserStartNodes);
-
     // default implementation to avoid breaking changes falls back to old behaviour
     IEnumerable<ISearchResult> Search(
         string query,
@@ -40,6 +18,5 @@ IEnumerable<ISearchResult> Search(
         string[]? contentTypeAliases,
         bool? trashed,
         string? searchFrom = null,
-        bool ignoreUserStartNodes = false)
-        => Search(query, entityType, pageSize, pageIndex, out totalFound, null, searchFrom, ignoreUserStartNodes);
+        bool ignoreUserStartNodes = false);
 }

src/Umbraco.Infrastructure/Examine/NoopBackOfficeExamineSearcher.cs

@@ -11,6 +11,8 @@ public IEnumerable<ISearchResult> Search(
         int pageSize,
         long pageIndex,
         out long totalFound,
+        string[]? contentTypeAliases,
+        bool? trashed,
         string? searchFrom = null,
         bool ignoreUserStartNodes = false)
     {