fix: default shouldExpandNodeInitially to false for collapsed nodes. #59

Author: jaywcjlove

core/README.md

@@ -735,7 +735,7 @@ export default function Demo() {
       collapsed={2}
       shouldExpandNodeInitially={(isExpanded, { value, keys, level }) => {
         if (keys.length > 0 && keys[0] == "object") {
-          return true
+          return false
         }
         return isExpanded
       }}

core/src/comps/KeyValues.tsx

@@ -25,11 +25,8 @@ export const KeyValues = <T extends object>(props: KeyValuesProps<T>) => {
   const defaultExpanded =
     typeof collapsed === 'boolean' ? collapsed : typeof collapsed === 'number' ? level > collapsed : false;
   const isExpanded = expands[expandKey] ?? defaultExpanded;
-  if (
-    expands[expandKey] === undefined &&
-    shouldExpandNodeInitially &&
-    shouldExpandNodeInitially(isExpanded, { value, keys, level })
-  ) {
+  const shouldExpand = shouldExpandNodeInitially && shouldExpandNodeInitially(!isExpanded, { value, keys, level });
+  if (expands[expandKey] === undefined && !shouldExpand) {
     return null;
   }
   if (isExpanded) {

core/src/comps/NestedClose.tsx

@@ -19,11 +19,8 @@ export const NestedClose = <T extends object>(props: NestedCloseProps<T>) => {
     typeof collapsed === 'boolean' ? collapsed : typeof collapsed === 'number' ? level > collapsed : false;
   const isExpanded = expands[expandKey] ?? defaultExpanded;
   const len = Object.keys(value!).length;
-  if (
-    expands[expandKey] === undefined &&
-    shouldExpandNodeInitially &&
-    shouldExpandNodeInitially(isExpanded, { value, keys, level })
-  ) {
+  const shouldExpand = shouldExpandNodeInitially && shouldExpandNodeInitially(!isExpanded, { value, keys, level });
+  if (expands[expandKey] === undefined && !shouldExpand) {
     return null;
   }
   if (isExpanded || len === 0) {

core/src/comps/NestedOpen.tsx

@@ -26,9 +26,9 @@ export const NestedOpen = <T extends object>(props: NestedOpenProps<T>) => {
     typeof collapsed === 'boolean' ? collapsed : typeof collapsed === 'number' ? level > collapsed : false;
   const isObject = typeof value === 'object';
   let isExpanded = expands[expandKey] ?? defaultExpanded;
-  const shouldExpand = shouldExpandNodeInitially && shouldExpandNodeInitially(isExpanded, { value, keys, level });
-  if (expands[expandKey] === undefined && shouldExpand !== undefined) {
-    isExpanded = shouldExpand;
+  const shouldExpand = shouldExpandNodeInitially && shouldExpandNodeInitially(!isExpanded, { value, keys, level });
+  if (expands[expandKey] === undefined && !shouldExpand) {
+    isExpanded = !shouldExpand;
   }
   const click = () => {
     const opt = { expand: !isExpanded, value, keyid: expandKey, keyName };