Skip to content

Make tests pass on Windows #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 4, 2023
Merged

Make tests pass on Windows #82

merged 1 commit into from
Jan 4, 2023

Conversation

AlexWaygood
Copy link
Contributor

I cloned stub_uploader to work on the stub_uploader CI failure in python/typeshed#9459, and was somewhat surprised when all the tests failed for me locally :)

hauntsaninja
hauntsaninja approved these changes Jan 4, 2023
View reviewed changes
Copy link
Contributor

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! (Jelle will need to merge)

@JelleZijlstra JelleZijlstra merged commit 6a36fb2 into typeshed-internal:main Jan 4, 2023
@AlexWaygood AlexWaygood deleted the windows-problems branch January 4, 2023 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

@hauntsaninja hauntsaninja hauntsaninja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlexWaygood @JelleZijlstra @hauntsaninja