Skip to content

forkmegithub과 a태그 겹치는 issue (ref #27, #30) #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 27, 2020
Merged

Conversation

guyeol
Copy link
Member

@guyeol guyeol commented Apr 27, 2020

해당 이슈 관련한 css 추가했습니다
local에서 돌렸을 땐 잘되네요
기존 네비게이션용 a태그에 top: 50px로 되어있는 것을 top: 50%
height는 적당히 100px로 했습니다

이외 npm script 보완이 필요한 부분 수정했습니다

피드백 부탁드립니다 :)

@guyeol
Copy link
Member Author

guyeol commented Apr 27, 2020

gitbook-cli 가 dependency에 없어 추가했습니다

@@ -4,6 +4,7 @@
"description": "[![Build Status](https://travis-ci.org/Microsoft/TypeScript-Handbook.svg)](https://travis-ci.org/Microsoft/TypeScript-Handbook)",
"main": "index.js",
"dependencies": {
"gitbook-cli": "^2.3.2",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@yeonjuan
Copy link
Contributor

#27, #30

Copy link
Member

@dvlprsh dvlprsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다👍👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants