Skip to content

test: correct out-of-date .shot files #11141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg commented May 5, 2025

PR Checklist

Overview

These are failing on main.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented May 5, 2025

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit c051873
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/6818ea00af076100082665ac
😎 Deploy Preview https://deploy-preview-11141--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 90 (🔴 down 8 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

nx-cloud bot commented May 5, 2025

View your CI Pipeline Execution ↗ for commit c051873.

Command Status Duration Result
nx typecheck ast-spec ✅ Succeeded <1s View ↗
nx run-many --target=build --exclude website --... ✅ Succeeded 49s View ↗
nx run-many --target=clean ✅ Succeeded 11s View ↗

☁️ Nx Cloud last updated this comment at 2025-05-05 17:14:58 UTC

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review May 5, 2025 16:42
@JoshuaKGoldberg JoshuaKGoldberg merged commit d450585 into typescript-eslint:main May 5, 2025
56 checks passed
Copy link

codecov bot commented May 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.91%. Comparing base (ccbfcdc) to head (c051873).
Report is 27 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11141      +/-   ##
==========================================
+ Coverage   90.90%   90.91%   +0.01%     
==========================================
  Files         498      499       +1     
  Lines       50655    50809     +154     
  Branches     8335     8369      +34     
==========================================
+ Hits        46049    46195     +146     
- Misses       4591     4599       +8     
  Partials       15       15              
Flag Coverage Δ
unittest 90.91% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 8 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Repo: Failures on main for ast-spec snapshots and rule-schemas no-unused-expressions > ignoreDirectives
1 participant