Fix type-checking of Django tests after removing fallback_to_any on Model.

- Correct arg type for sort_dependencies so they are covariant (Iterable rather than List).
- Added a stub for __getstate__ to Model.
- Added a stub for clean() to Model.
- Added some test ignores in cases where a model inherits from 2 different base models.
- Added some test ignores for cases that MyPy flags as errors due to variable redefinitions or imports that are incompatible types.

Author: syastrov

django-stubs/core/serializers/__init__.pyi

@@ -1,5 +1,4 @@
-from collections import OrderedDict
-from typing import Any, Callable, Dict, Iterator, List, Optional, Tuple, Type, Union
+from typing import Any, Callable, Dict, Iterator, List, Optional, Tuple, Type, Union, Iterable
 
 from django.apps.config import AppConfig
 from django.db.models.base import Model
@@ -33,5 +32,5 @@ def serialize(
 ) -> Optional[Union[bytes, str]]: ...
 def deserialize(format: str, stream_or_string: Any, **options: Any) -> Union[Iterator[Any], Deserializer]: ...
 def sort_dependencies(
-    app_list: Union[List[Tuple[AppConfig, None]], List[Tuple[str, List[Type[Model]]]]]
+    app_list: Union[Iterable[Tuple[AppConfig, None]], Iterable[Tuple[str, Iterable[Type[Model]]]]]
 ) -> List[Type[Model]]: ...

django-stubs/db/models/base.pyi

@@ -16,6 +16,7 @@ class Model(metaclass=ModelBase):
     def __init__(self: _Self, *args, **kwargs) -> None: ...
     def delete(self, using: Any = ..., keep_parents: bool = ...) -> Tuple[int, Dict[str, int]]: ...
     def full_clean(self, exclude: Optional[List[str]] = ..., validate_unique: bool = ...) -> None: ...
+    def clean(self) -> None: ...
     def clean_fields(self, exclude: List[str] = ...) -> None: ...
     def validate_unique(self, exclude: List[str] = ...) -> None: ...
     def save(
@@ -35,6 +36,8 @@ class Model(metaclass=ModelBase):
     ): ...
     def refresh_from_db(self: _Self, using: Optional[str] = ..., fields: Optional[List[str]] = ...) -> _Self: ...
     def get_deferred_fields(self) -> Set[str]: ...
+    def __getstate__(self) -> dict: ...
+
 
 class ModelStateFieldsCacheDescriptor: ...
 

scripts/typecheck_tests.py

@@ -213,11 +213,13 @@
         'Unexpected keyword argument "headline__startswith" for "in_bulk" of "QuerySet"',
     ],
     'many_to_one': [
-        'Incompatible type for "parent" of "Child" (got "None", expected "Union[Parent, Combinable]")'
+        'Incompatible type for "parent" of "Child" (got "None", expected "Union[Parent, Combinable]")',
+        'Incompatible type for "parent" of "Child" (got "Child", expected "Union[Parent, Combinable]")'
     ],
     'model_meta': [
         '"object" has no attribute "items"',
-        '"Field" has no attribute "many_to_many"'
+        '"Field" has no attribute "many_to_many"',
+        re.compile(r'Definition of "(objects|_default_manager)" in base class "FirstParent" is incompatible with definition in base class "SecondParent"'),
     ],
     'model_forms': [
         'Argument "instance" to "InvalidModelForm" has incompatible type "Type[Category]"; expected "Optional[Model]"',
@@ -229,14 +231,22 @@
         'Cannot assign multiple types to name "PersonTwoImages" without an explicit "Type[...]" annotation',
         'Incompatible types in assignment (expression has type "Type[Person]", '
         + 'base class "ImageFieldTestMixin" defined the type as "Type[PersonWithHeightAndWidth]")',
-    ],
+        re.compile(
+            r'Incompatible types in assignment \(expression has type "Type\[.+?\]", base class "IntegerFieldTests" defined the type as "Type\[IntegerModel\]"\)'),
+        re.compile(r'Incompatible types in assignment \(expression has type "Type\[.+?\]", base class "ImageFieldTestMixin" defined the type as "Type\[PersonWithHeightAndWidth\]"\)'),
+        'Incompatible import of "Person"',
+        'Incompatible types in assignment (expression has type "FloatModel", variable has type "Union[float, int, str, Combinable]")',
+   ],
     'model_formsets': [
         'Incompatible types in string interpolation (expression has type "object", '
         + 'placeholder has type "Union[int, float]")'
     ],
     'model_formsets_regress': [
         'Incompatible types in assignment (expression has type "Model", variable has type "User")'
     ],
+    'model_inheritance_regress': [
+        re.compile(r'Definition of "(objects|_default_manager)" in base class "Person" is incompatible with definition in base class "Politician"'),
+    ],
     'model_regress': [
         'Too many arguments for "Worker"',
         re.compile(r'Incompatible type for "[a-z]+" of "Worker" \(got "int", expected')
@@ -261,7 +271,8 @@
         'Argument 1 to "RunPython" has incompatible type "str"; expected "Callable[..., Any]"',
         'FakeLoader',
         'Argument 1 to "append" of "list" has incompatible type "AddIndex"; expected "CreateModel"',
-        'Unsupported operand types for - ("Set[Any]" and "None")'
+        'Unsupported operand types for - ("Set[Any]" and "None")',
+        re.compile(r'Definition of "(objects|_default_manager)" in base class "Foo" is incompatible with definition in base class "Bar"'),
     ],
     'middleware_exceptions': [
         'Argument 1 to "append" of "list" has incompatible type "Tuple[Any, Any]"; expected "str"'
@@ -282,7 +293,9 @@
         + 'expected "Optional[Type[JSONEncoder]]"',
         'for model "CITestModel"',
         'Incompatible type for "field" of "IntegerArrayModel" (got "None", '
-        + 'expected "Union[Sequence[int], Combinable]")'
+        + 'expected "Union[Sequence[int], Combinable]")',
+        re.compile(r'Incompatible types in assignment \(expression has type "Type\[.+?\]", base class "UnaccentTest" defined the type as "Type\[CharFieldModel\]"\)'),
+        'Incompatible types in assignment (expression has type "Type[TextFieldModel]", base class "TrigramTest" defined the type as "Type[CharFieldModel]")',
     ],
     'properties': [
         re.compile('Unexpected attribute "(full_name|full_name_2)" for model "Person"')
@@ -291,6 +304,11 @@
         'Incompatible types in assignment (expression has type "None", variable has type "str")',
         'Invalid index type "Optional[str]" for "Dict[str, int]"; expected type "str"',
         'No overload variant of "values_list" of "QuerySet" matches argument types "str", "bool", "bool"',
+        'Unsupported operand types for & ("QuerySet[Author, Author]" and "QuerySet[Tag, Tag]")',
+        'Unsupported operand types for | ("QuerySet[Author, Author]" and "QuerySet[Tag, Tag]")',
+        'Incompatible types in assignment (expression has type "ObjectB", variable has type "ObjectA")',
+        'Incompatible types in assignment (expression has type "ObjectC", variable has type "ObjectA")',
+        'Incompatible type for "objectb" of "ObjectC" (got "ObjectA", expected "Union[ObjectB, Combinable, None, None]")',
     ],
     'requests': [
         'Incompatible types in assignment (expression has type "Dict[str, str]", variable has type "QueryDict")'
@@ -303,6 +321,9 @@
         '"None" has no attribute "__iter__"',
         'has no attribute "read_by"'
     ],
+    'proxy_model_inheritance': [
+        'Incompatible import of "ProxyModel"'
+    ],
     'signals': [
         'Argument 1 to "append" of "list" has incompatible type "Tuple[Any, Any, Optional[Any], Any]"; '
         + 'expected "Tuple[Any, Any, Any]"'
@@ -387,7 +408,10 @@
         'Incompatible types in assignment (expression has type "None", variable has type "int")',
     ],
     'select_related_onetoone': [
-        '"None" has no attribute'
+        '"None" has no attribute',
+        'Incompatible types in assignment (expression has type "Parent2", variable has type "Parent1")',
+        'Definition of "objects" in base class "Parent1" is incompatible with definition in base class "Parent2"',
+        'Definition of "_default_manager" in base class "Parent1" is incompatible with definition in base class "Parent2"',
     ],
     'servers': [
         re.compile('Argument [0-9] to "WSGIRequestHandler"')