Skip to content

fix: date time conversion to String #625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 11, 2021
Merged

fix: date time conversion to String #625

merged 1 commit into from
Mar 11, 2021

Conversation

eshanholtz
Copy link
Contributor

Java OffsetDateTime Objects truncate zero fields, whereas Instant Objects do not. ZonedDateTime Objects should be converted to the proper format via ZonedDateTime.toInstant().toString(). The added test failed using the previous conversion process, ZonedDateTime.toOffsetDateTime().toString(), due to the seconds being truncated.

Copy link
Contributor

@thinkingserious thinkingserious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants