Skip to content

Resolve pipe character in URI #557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Resolve pipe character in URI #557

wants to merge 3 commits into from

Conversation

tjrbrom
Copy link

@tjrbrom tjrbrom commented Jul 6, 2020

Fixes

A short description of what this PR does.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the master branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

@tjrbrom
Copy link
Author

tjrbrom commented Jul 7, 2020

Suggest using URLEncoder.encode() instead replace() to get other illegal characters.

It seems that com.twilio.jwt.validation.RequestCanonicalizer class does the needed work of encoding and replacing characters, although we cannot access it in com.twilio.http.Request cause it's not public...

@eshanholtz
Copy link
Contributor

Hi @tjrbrom

After reviewing your PR, I went ahead and implemented a fix to handle all instances of path parameter encodings. I'm closing this PR in favor of #558

Thanks!

@eshanholtz eshanholtz closed this Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants