chore: Update jjwt dependency version 0.10.7 #514
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
With modularization jjwt made in 0.10.0, it’s fairly easy to accidentally have multiple implementations of jjwt on the classpath, because |
eager
commented
Jan 29, 2020
| @@ -17,7 +17,7 @@ | |||
|
|
|||
| private static final String ACCOUNT_SID = "AC123"; | |||
| private static final String SIGNING_KEY_SID = "SK123"; | |||
| private static final String SECRET = "secret"; | |||
| private static final String SECRET = "secretsecretsecretsecretsecret00"; | |||
There was a problem hiding this comment.
I updated these to meet the minimum key length and avoid WeakKeyExceptions. Do they need an inline comment?
There was a problem hiding this comment.
I think it's fine w/o a comment.
childish-sambino
approved these changes
Feb 4, 2020
| @@ -17,7 +17,7 @@ | |||
|
|
|||
| private static final String ACCOUNT_SID = "AC123"; | |||
| private static final String SIGNING_KEY_SID = "SK123"; | |||
| private static final String SECRET = "secret"; | |||
| private static final String SECRET = "secretsecretsecretsecretsecret00"; | |||
There was a problem hiding this comment.
I think it's fine w/o a comment.
FalguniV
pushed a commit
to FalguniV/twilio-java
that referenced
this pull request
Oct 13, 2020
* Update jjwt dependency to 0.10.7 * Update tests to use minimum-length secrets
FalguniV
pushed a commit
to FalguniV/twilio-java
that referenced
this pull request
Oct 13, 2020
* Update jjwt dependency to 0.10.7 * Update tests to use minimum-length secrets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the jjwt dependency to 0.10.7.
Checklist