Skip to content

Prefix client identifiers with 'client:' if not already prefixed #458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 22, 2019
Merged

Prefix client identifiers with 'client:' if not already prefixed #458

merged 1 commit into from
May 22, 2019

Conversation

childish-sambino
Copy link
Contributor

Contributing to Twilio

All third party contributors acknowledge that any contributions they provide will be made under the same open source license that the open source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

Similar to twilio/twilio-csharp#456

@childish-sambino
Copy link
Contributor Author

Actually, need to do case-insensitive comparison since CLIENT:jeff is legitimate. I'll link a separate PR.

@childish-sambino childish-sambino merged commit d02075d into master May 22, 2019
@childish-sambino childish-sambino deleted the client-prefix branch May 22, 2019 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thinkingserious thinkingserious thinkingserious approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@childish-sambino @thinkingserious