Skip to content

Refactor Bazel configuration to reduce/eliminate platform-specific flags #2099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
cgrindel opened this issue Jan 4, 2024 · 3 comments
Open

Refactor Bazel configuration to reduce/eliminate platform-specific flags #2099

cgrindel opened this issue Jan 4, 2024 · 3 comments
Assignees
@cgrindel
Labels
type: feature request

Comments

@cgrindel
Copy link
Contributor

cgrindel commented Jan 4, 2024 •
edited
Loading

Is your feature request related to a problem? Please describe.

This repository defines named configurations based upon platform (e.g. linux-nixpkgs, macos-nixpkgs, linux-bindist, macos-bindist). In theory, some/all of the configuration could be migrated to platform discovery features using target_compatible_with or select().

Describe the solution you'd like

Review the OS-specific configuration settings and propose alternative implementations.
@cgrindel cgrindel mentioned this issue Jan 4, 2024
Closed
@cgrindel cgrindel self-assigned this Jan 4, 2024
@cgrindel cgrindel mentioned this issue Jan 5, 2024
Merged
cgrindel added a commit that referenced this issue Jan 8, 2024
@cgrindel
chore: configure OS-specific variables in .bazelrc (#2102)
284a79c 
- Add `--enable_platform_specific_config` to `.bazelrc.common`.
- Move MacOS- and Windows-specific environment variables to `.bazelrc.common` under their OS config names.
- Update code that generates bazelrc files for integration tests to include the new entries.

Related to #2099.
This was referenced Jan 8, 2024
Closed
Draft
@cgrindel
Copy link
Contributor Author

cgrindel commented Jan 8, 2024

How to detect if in a Nix shell: nix-shell vs nix shell.

@cgrindel
Copy link
Contributor Author

cgrindel commented Jan 8, 2024

More on how to detect if in Nix shell

@cgrindel cgrindel mentioned this issue Jan 9, 2024
Closed
@cgrindel
Copy link
Contributor Author

Quick update:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cgrindel cgrindel

Labels
type: feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cgrindel