Skip to content

whe I give non-existant file names, it segfaults #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dataf3l opened this issue Oct 17, 2023 · 2 comments
Closed

whe I give non-existant file names, it segfaults #3

dataf3l opened this issue Oct 17, 2023 · 2 comments

Comments

@dataf3l
Copy link

dataf3l commented Oct 17, 2023

these files do not exist:

models/*

I get this error

➜  llava-cpp-server git:(main) ./bin/llava-server -m ./models/ggml-model-q5_k.gguf --mmproj ./models/mmproj-model-f16.gguf
[1]    57986 segmentation fault  ./bin/llava-server -m ./models/ggml-model-q5_k.gguf --mmproj

what I kinda expected:
"sorry this file doesn't exist"

thanks in advance

@trzy
Copy link
Owner

trzy commented Oct 18, 2023

Great catch but this is actually a problem with llama.cpp itself, which handles command line parsing and model file loading. That is, if you go into llama.cpp/ (or clone that repo independently and build it), and run ./llava with nonexistant filenames, the same segfault occurs. I want to refrain from reaching inside of llama.cpp but this would be a good issue to file with them directly.

@dataf3l
Copy link
Author

dataf3l commented Oct 18, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants