Skip to content

whe I give non-existant file names, it segfaults #3 #3663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dataf3l opened this issue Oct 18, 2023 · 1 comment · Fixed by #3674
Closed

whe I give non-existant file names, it segfaults #3 #3663

dataf3l opened this issue Oct 18, 2023 · 1 comment · Fixed by #3674
Labels
good first issue Good for newcomers

Comments

@dataf3l
Copy link

dataf3l commented Oct 18, 2023

I was told to come here by this other dude:

trzy/llava-cpp-server#3 (comment)

ISSUE: when I give non-existant file names, it segfaults #3

these files do not exist:

models/*

I get this error

➜ llava-cpp-server git:(main) ./bin/llava-server -m ./models/ggml-model-q5_k.gguf --mmproj ./models/mmproj-model-f16.gguf
[1] 57986 segmentation fault ./bin/llava-server -m ./models/ggml-model-q5_k.gguf --mmproj

what I kinda expected:
"sorry this file doesn't exist"

thanks in advance

That's all you need to read.

Please answer the following questions for yourself before submitting an issue.

Oh boy, I'm not sure my feeling are ready to fill out the form.
here is a meme instead:

st,small,507x507-pad,600x600,f8f8f8

I'll just see myself out.

Expected Behavior

NOT a SEGFAULT, maybe a nice error message, on STDERR? idk.

Current Behavior

a segfault, as mentioned earlier.

Environment and Context

osx m1, Physical

[$ lscpu](zsh: command not found: lscpu)

  • Operating System, e.g. for Linux:

ARM M1 (Yeah, I know, it sucks, but like, that's what they apple ppls are building these days).
God I miss intel...

Darwin m1.local 21.6.0 Darwin Kernel Version 21.6.0: Wed Aug 10 14:28:35 PDT 2022; root:xnu-8020.141.5~2/RELEASE_ARM64_T8101 arm64

  • SDK version, e.g. for Linux:
Python 3.11.4
GNU Make 3.81
Apple clang version 13.1.6 (clang-1316.0.21.2.5)
Target: arm64-apple-darwin21.6.0
Thread model: posix
InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin

Failure Information (for bugs)

➜ llava-cpp-server git:(main) ./bin/llava-server -m ./models/ggml-model-q5_k.gguf --mmproj ./models/mmproj-model-f16.gguf
[1] 57986 segmentation fault ./bin/llava-server -m ./models/ggml-model-q5_k.gguf --mmproj

i KNOW it's another program, but he says I should come here, so there.

Steps to Reproduce

Step 1. just give it bad files (non-existant) in the cmd line and watch it segfault on m1 osx.
Step 2. make coffee
Step 3. Cry

"We are not sitting in front of your screen"

Never have I ever read such a drastic warning on a github template, guys, like, chill.

Failure Logs

[1] 57986 segmentation fault ./bin/llava-server -m ./models/ggml-model-q5_k.gguf --mmproj

Example environment info:


➜  llava-cpp-server git:(main) ls
➜  llava-cpp-server git:(main) cd llama.cpp
➜  llama.cpp git:(b1380) git log | head -1
commit 2a4bcbacead886996f175f33479d1d874a3e577f

lscpu didn't even install, sorry guys.
Error: No formulae or casks found for lscpu.

So I hope this helps, see you in 2026 fellas. or whenever you get to this one.

you guys are my heroes, just so you know
@dataf3l
Copy link
Author

dataf3l commented Oct 19, 2023

oh Dang!, thanks guys, I love all of you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants