BuiltinFunctions can absolutely keep a Realm alive

aapoalas · aapoalas · commit c128e8ff6928 · 2024-07-24T06:51:14.000+03:00
diff --git a/nova_vm/src/ecmascript/builtins/builtin_function.rs b/nova_vm/src/ecmascript/builtins/builtin_function.rs
@@ -712,8 +712,7 @@ impl HeapMarkAndSweep for BuiltinFunction {
 
 impl HeapMarkAndSweep for BuiltinFunctionHeapData {
     fn mark_values(&self, queues: &mut WorkQueues) {
-        // Note: Builtin functions cannot keep their realm alive.
-        // self.realm.mark_values(queues);
+        self.realm.mark_values(queues);
         self.initial_name.mark_values(queues);
         self.object_index.mark_values(queues);
     }

Original file line number	Diff line number	Diff line change
`@@ -712,8 +712,7 @@ impl HeapMarkAndSweep for BuiltinFunction {`
`712`	`712`
`713`	`713`	`impl HeapMarkAndSweep for BuiltinFunctionHeapData {`
`714`	`714`	`fn mark_values(&self, queues: &mut WorkQueues) {`
`715`		`- // Note: Builtin functions cannot keep their realm alive.`
`716`		`- // self.realm.mark_values(queues);`
	`715`	`+ self.realm.mark_values(queues);`
`717`	`716`	`self.initial_name.mark_values(queues);`
`718`	`717`	`self.object_index.mark_values(queues);`
`719`	`718`	`}`