Skip to content

"Dev connecting" icon update + text color fix for the purple login buttons #1835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 28, 2025

Conversation

samejr
Copy link
Member

@samejr samejr commented Mar 28, 2025

Updated the Dev connecting icon to include a "loading" indicator on the screen

CleanShot 2025-03-28 at 10 34 46@2x

Makes the text and icons on the new primary login page buttons light instead of dark grey

CleanShot 2025-03-28 at 10 13 16@2x
CleanShot 2025-03-28 at 10 13 32@2x

Summary by CodeRabbit

  • Style
    • Enhanced the connection icon with refined visual elements.
    • Refreshed the GitHub login button with an updated icon and improved text styling.
    • Updated the magic link page with adjusted icon, spinner, and text colors for a more consistent appearance.

Copy link

changeset-bot bot commented Mar 28, 2025

⚠️ No Changeset found

Latest commit: cc61068

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

coderabbitai bot commented Mar 28, 2025

Walkthrough

This update makes several UI modifications. The ConnectionIcons component now includes additional circles, enhancing its SVG representation. In the login routes, the GitHub icon and various text and button styling properties have been updated. The magic link page also sees changes in spinner, icon, and text colors to maintain visual consistency across the authentication interfaces.

Changes

File(s) Change Summary
apps/.../assets/icons/ConnectionIcons.tsx Added three <circle> elements (positions: (9,11), (12,11), (15,11), radius: 1, fill: #878C99) to the CheckingConnectionIcon SVG structure.
apps/.../routes/login._index/route.tsx,
apps/.../routes/login.magic/route.tsx
Replaced GitHubDarkIcon with GitHubLightIcon, updated text color classes, and changed the LinkButton variant in the login page; modified spinner, envelope icon, and text colors in the magic link page for enhanced UI styling.

Suggested reviewers

  • matt-aitken

Poem

I'm a rabbit in the codefield, so spry,
Hopping over icons that catch your eye.
Circles and colors dance in the light,
Making login buttons look just right.
With every tweak, I cheer with glee,
Code and carrots in joyous harmony!
🐰✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 49c43a1 and cc61068.

📒 Files selected for processing (3)
  • apps/webapp/app/assets/icons/ConnectionIcons.tsx (1 hunks)
  • apps/webapp/app/routes/login._index/route.tsx (2 hunks)
  • apps/webapp/app/routes/login.magic/route.tsx (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: units / 🧪 Unit Tests
🔇 Additional comments (7)
apps/webapp/app/assets/icons/ConnectionIcons.tsx (1)

68-70: Improved connection loading indicator UI

The addition of three small circles creates a recognizable "loading" visual pattern, enhancing the user experience during connection processes. This matches the PR objective of providing better visual cues during connection.

apps/webapp/app/routes/login.magic/route.tsx (3)

178-178: Improved spinner color contrast

Changing the spinner color to white enhances visibility on the primary button background.


180-180: Enhanced envelope icon visibility

The text-text-bright class makes the icon more visible against the button background.


183-186: Improved button text contrast

Changing both the "Sending..." loading text and the "Send a magic link" button text to text-text-bright improves visibility and creates visual consistency with other login page elements.

apps/webapp/app/routes/login._index/route.tsx (3)

4-4: Updated GitHub icon import

Changed from the dark version to the light version to match the UI modifications in the PR.


92-93: Enhanced GitHub button readability

The GitHub icon has been changed to the light version and text color updated to text-text-bright, improving visibility on the button background as specified in the PR objectives.


98-99: Updated email button styling

Changed the variant from what was likely "tertiary/extra-large" to "secondary/extra-large", which creates better visual hierarchy and consistency with the other UI changes in this PR.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@matt-aitken matt-aitken merged commit f3efdad into main Mar 28, 2025
12 checks passed
@matt-aitken matt-aitken deleted the icons-update branch March 28, 2025 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants