Handle gh install updates separately from new installs

Author: myftija

apps/webapp/app/routes/_app.github.callback/route.tsx

@@ -1,7 +1,7 @@
 import { type LoaderFunctionArgs } from "@remix-run/node";
 import { z } from "zod";
 import { validateGitHubAppInstallSession } from "~/services/gitHubSession.server";
-import { linkGitHubAppInstallation } from "~/services/gitHub.server";
+import { linkGitHubAppInstallation, updateGitHubAppInstallation } from "~/services/gitHub.server";
 import { logger } from "~/services/logger.server";
 import { redirectWithErrorMessage, redirectWithSuccessMessage } from "~/models/message.server";
 import { tryCatch } from "@trigger.dev/core";
@@ -76,8 +76,7 @@ export async function loader({ request }: LoaderFunctionArgs) {
   }
 
   switch (callbackData.setup_action) {
-    case "install":
-    case "update": {
+    case "install": {
       const [error] = await tryCatch(
         linkGitHubAppInstallation(callbackData.installation_id, organizationId)
       );
@@ -92,6 +91,19 @@ export async function loader({ request }: LoaderFunctionArgs) {
       return redirectWithSuccessMessage(redirectTo, request, "GitHub App installed successfully");
     }
 
+    case "update": {
+      const [error] = await tryCatch(updateGitHubAppInstallation(callbackData.installation_id));
+
+      if (error) {
+        logger.error("Failed to update GitHub App installation", {
+          error,
+        });
+        return redirectWithErrorMessage(redirectTo, request, "Failed to update GitHub App");
+      }
+
+      return redirectWithSuccessMessage(redirectTo, request, "GitHub App updated successfully");
+    }
+
     case "request": {
       // This happens when a non-admin user requests installation
       // The installation_id won't be available until an admin approves

apps/webapp/app/services/gitHub.server.ts

@@ -56,6 +56,50 @@ export async function linkGitHubAppInstallation(
   });
 }
 
+/**
+ * Links a GitHub App installation to a Trigger organization
+ */
+export async function updateGitHubAppInstallation(installationId: number): Promise<void> {
+  if (!githubApp) {
+    throw new Error("GitHub App is not enabled");
+  }
+
+  const octokit = await githubApp.getInstallationOctokit(installationId);
+  const { data: installation } = await octokit.rest.apps.getInstallation({
+    installation_id: installationId,
+  });
+
+  const existingInstallation = await prisma.githubAppInstallation.findFirst({
+    where: { appInstallationId: installationId },
+  });
+
+  if (!existingInstallation) {
+    throw new Error("GitHub App installation not found");
+  }
+
+  const repositorySelection = installation.repository_selection === "all" ? "ALL" : "SELECTED";
+
+  // repos are updated asynchronously via webhook events
+  await prisma.githubAppInstallation.update({
+    where: { id: existingInstallation?.id },
+    data: {
+      appInstallationId: installationId,
+      targetId: installation.target_id,
+      targetType: installation.target_type,
+      accountHandle: installation.account
+        ? "login" in installation.account
+          ? installation.account.login
+          : "slug" in installation.account
+          ? installation.account.slug
+          : "-"
+        : "-",
+      permissions: installation.permissions,
+      suspendedAt: existingInstallation?.suspendedAt,
+      repositorySelection,
+    },
+  });
+}
+
 async function fetchInstallationRepositories(octokit: Octokit, installationId: number) {
   const iterator = octokit.paginate.iterator(octokit.rest.apps.listReposAccessibleToInstallation, {
     installation_id: installationId,