Merge branch 'main' into tm-npm-workspaces-lock-file

Author: trentm

package.json

@@ -40,8 +40,8 @@
   "author": "OpenTelemetry Authors",
   "license": "Apache-2.0",
   "devDependencies": {
-    "@commitlint/cli": "16.0.2",
-    "@commitlint/config-conventional": "16.0.0",
+    "@commitlint/cli": "18.4.1",
+    "@commitlint/config-conventional": "18.4.0",
     "@typescript-eslint/eslint-plugin": "5.8.1",
     "@typescript-eslint/parser": "5.8.1",
     "eslint": "8.7.0",

plugins/node/opentelemetry-instrumentation-aws-sdk/src/services/sns.ts

@@ -42,6 +42,9 @@ export class SnsServiceExtension implements ServiceExtension {
       const { TopicArn, TargetArn, PhoneNumber } = request.commandInput;
       spanAttributes[SemanticAttributes.MESSAGING_DESTINATION] =
         this.extractDestinationName(TopicArn, TargetArn, PhoneNumber);
+      // ToDO: Use SpanAttributes.MESSAGING_DESTINATION_NAME when implemented
+      spanAttributes['messaging.destination.name'] =
+        TopicArn || TargetArn || PhoneNumber || 'unknown';
 
       spanName = `${
         PhoneNumber

plugins/node/opentelemetry-instrumentation-aws-sdk/test/sns.test.ts

@@ -84,6 +84,9 @@ describe('SNS - v2', () => {
       expect(
         publishSpan.attributes[SemanticAttributes.MESSAGING_DESTINATION]
       ).toBe(topicName);
+      expect(publishSpan.attributes['messaging.destination.name']).toBe(
+        fakeARN
+      );
       expect(publishSpan.attributes[SemanticAttributes.RPC_METHOD]).toBe(
         'Publish'
       );
@@ -111,6 +114,9 @@ describe('SNS - v2', () => {
       expect(
         publishSpan.attributes[SemanticAttributes.MESSAGING_DESTINATION]
       ).toBe(PhoneNumber);
+      expect(publishSpan.attributes['messaging.destination.name']).toBe(
+        PhoneNumber
+      );
     });
 
     it('inject context propagation', async () => {
@@ -159,6 +165,9 @@ describe('SNS - v2', () => {
       expect(
         createTopicSpan.attributes[SemanticAttributes.MESSAGING_DESTINATION]
       ).toBeUndefined();
+      expect(
+        createTopicSpan.attributes['messaging.destination.name']
+      ).toBeUndefined();
       expect(createTopicSpan.kind).toBe(SpanKind.CLIENT);
     });
   });
@@ -186,9 +195,11 @@ describe('SNS - v3', () => {
   describe('publish', () => {
     it('topic arn', async () => {
       const topicV3Name = 'dummy-sns-v3-topic';
+      const topicV3ARN = `arn:aws:sns:us-east-1:000000000:${topicV3Name}`;
+
       await sns.publish({
         Message: 'sns message',
-        TopicArn: `arn:aws:sns:us-east-1:000000000:${topicV3Name}`,
+        TopicArn: topicV3ARN,
       });
 
       const publishSpans = getTestSpans().filter(
@@ -203,6 +214,9 @@ describe('SNS - v3', () => {
       expect(
         publishSpan.attributes[SemanticAttributes.MESSAGING_DESTINATION]
       ).toBe(topicV3Name);
+      expect(publishSpan.attributes['messaging.destination.name']).toBe(
+        topicV3ARN
+      );
       expect(publishSpan.attributes[SemanticAttributes.RPC_METHOD]).toBe(
         'Publish'
       );