Possible fix for issue #249. Further testing called for.

Author: trampgeek

backup/moodle2/restore_qtype_coderunner_plugin.class.php

@@ -149,9 +149,6 @@ public function process_coderunner_options($data) {
     public static function convert_backup_to_questiondata(array $backupdata): stdClass {
         $questiondata = parent::convert_backup_to_questiondata($backupdata);
         $qtype = $questiondata->qtype;
-        if ($qtype !== 'coderunner' || !isset($backupdata["plugin_qtype_{$qtype}_question"]['coderunner_testcases'])) {
-            return $questiondata;
-        }
 
         $questiondata->options->testcases = [];
         foreach ($backupdata["plugin_qtype_{$qtype}_question"]['coderunner_testcases']['coderunner_testcase'] as $record) {
@@ -180,6 +177,7 @@ protected function define_excluded_identity_hash_fields(): array {
             '/hints',
             '/prototype',
             '/options/customise',
+            '/options/templateparamsevald',
             '/options/testcases/id',
             '/options/testcases/questionid',
         ];
@@ -196,6 +194,9 @@ public static function remove_excluded_question_data(stdClass $questiondata, arr
         if (isset($questiondata->answers)) {
             unset($questiondata->answers);
         }
+        if (isset($questiondata->options->answers)) {
+            unset($questiondata->options->answers);
+        }
         if (isset($questiondata->hints)) {
             unset($questiondata->hints);
         }

questiontype.php

@@ -82,6 +82,12 @@ public function can_analyse_responses() {
      * @return mixed array as above, or null to tell the base class to do nothing.
      */
     public function extra_question_fields() {
+        return self::extra_question_fields_static();
+    }
+
+    // We need access to this list of extra question fields during quiz duplication
+    // (when no actual question exists) so I make it static.
+    public static function extra_question_fields_static() {
         return ['question_coderunner_options',
             'coderunnertype',
             'prototypetype',
@@ -420,8 +426,12 @@ public function get_question_options($question) {
         } else {
             $qtype = $options->coderunnertype;
             $context = $this->question_context($question);
-            $question->prototype = $this->get_prototype($qtype, $context);
-            $this->set_inherited_fields($options, $question->prototype);
+            $prototype = $this->get_prototype($qtype, $context);
+            if (!($question->export_process ?? false)) {
+                // Don't inherit fields when exporting during quiz duplication or backup restore.
+                $this->set_inherited_fields($options, $prototype);
+                $question->prototype = $prototype;
+            }
         }
 
         // Add in any testcases.