Skip to content

fix(costs): fix cost route to /cost from /costs #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

avivhalfon
Copy link
Contributor

@avivhalfon avivhalfon commented Apr 29, 2025

Important

Fix API endpoint path in property_costs.mdx from /costs to /cost.

  • API Endpoint:
    • Change API endpoint path from /api/v2/costs/by-association-property to /api/v2/cost/by-association-property in property_costs.mdx.

This description was created by Ellipsis for 170971b. You can customize this summary. It will automatically update as commits are pushed.

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to 170971b in 29 seconds. Click for details.
  • Reviewed 12 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 3 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. api-reference/costs/property_costs.mdx:3
  • Draft comment:
    URL update to '/cost/by-association-property' confirmed, ensure backend routing matches this change.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% The comment is asking to ensure that the backend routing matches the updated URL. This is a request to double-check something, which violates the rule against asking the PR author to confirm or ensure behavior. Therefore, this comment should be removed.
2. api-reference/costs/property_costs.mdx:3
  • Draft comment:
    Updated API URL to '/cost/by-association-property'. Ensure consistency with backend endpoints.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% The comment is asking the author to ensure consistency with backend endpoints, which is a form of asking for confirmation or verification. This violates the rule against asking the PR author to confirm or ensure things. The comment does not provide a specific suggestion or point out a specific issue, so it should be removed.
3. api-reference/costs/property_costs.mdx:23
  • Draft comment:
    Minor typographical issue: In the description for the 'env' parameter (line 23), consider changing 'Separated by comma.' to 'Separated by commas.' for grammatical accuracy.
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.

Workflow ID: wflow_ujdigRZFEGKhcmbS

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant