Skip to content

Support for environment files in set_env #2223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 18, 2021
Merged

Support for environment files in set_env #2223

merged 2 commits into from
Sep 18, 2021

Conversation

gaborbernat
Copy link
Member

@gaborbernat gaborbernat commented Sep 17, 2021

Resolves #1938.

@codecov
Copy link

codecov bot commented Sep 17, 2021

Codecov Report

Merging #2223 (8cf1ea7) into rewrite (cf1a2be) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           rewrite    #2223   +/-   ##
========================================
  Coverage    99.86%   99.86%           
========================================
  Files          162      162           
  Lines         9397     9434   +37     
  Branches       961      967    +6     
========================================
+ Hits          9384     9421   +37     
  Misses           3        3           
  Partials        10       10           
Flag Coverage Δ
tests 99.86% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/tox/config/loader/ini/__init__.py 100.00% <100.00%> (ø)
src/tox/config/set_env.py 100.00% <100.00%> (ø)
src/tox/config/sets.py 100.00% <100.00%> (ø)
src/tox/pytest.py 100.00% <100.00%> (ø)
src/tox/tox_env/errors.py 100.00% <100.00%> (ø)
tests/config/test_set_env.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf1a2be...8cf1ea7. Read the comment docs.

Copy link
Member

@jugmac00 jugmac00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with some annotations 🚀

Signed-off-by: Bernát Gábor <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants