-
-
Notifications
You must be signed in to change notification settings - Fork 533
Add support for exec subcommand #2142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Run arbitrary commands within your tox environment. Don't abuse it. Signed-off-by: Bernát Gábor <[email protected]>
Codecov Report
@@ Coverage Diff @@
## rewrite #2142 +/- ##
========================================
Coverage 99.85% 99.85%
========================================
Files 155 157 +2
Lines 8693 8744 +51
Branches 918 921 +3
========================================
+ Hits 8680 8731 +51
Misses 3 3
Partials 10 10
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While there are several potentially dangerous configuration options (e.g. delete directories) already present in tox, this one is special - let's hope for the best 👍
@asottile Any opinion on this one?
I am not super happy with the autogenerated documentation, as at least I could not see that the command needs to be passed in after a double dash --
.
Is there anything we could do with the autogenerated docs or maybe should we add a FAQ entry? Although - technically it is not a frequently asked question :-)
Co-authored-by: Jürgen Gmach <[email protected]>
It's documented in the epilogue of the sub-command (see tox4 |
Signed-off-by: Bernát Gábor <[email protected]>
Thanks - |
Created tox-dev/sphinx-argparse-cli#20 to address that. |
I don't think it's overly dangerous. Users can already invoke commands within the tox environments (as in |
Run arbitrary commands within your tox environment. Don't abuse it.
Resolves #1790