Dont pass around re match object #1712
Conversation
jayvdb
requested review from
asottile,
gaborbernat and
obestwalter
as code owners
|
The CI failure here is #1699 (comment) This PR also needs doc amendments IMO, as described on #1711 |
src/tox/config/__init__.py
Outdated
|
|
||
| try: |
There was a problem hiding this comment.
#1715 is the prefered approach for this chunk.
I'll rebase after that is merged, assuming it is accepted.
There was a problem hiding this comment.
Rebased; im ambivalent about whether this is merged or not. Also it feels odd writing a changelog entry for this. I'd be fine with slipping this into another PR to avoid it being a standalone changelog entry.
jayvdb
force-pushed
the
dont-pass-around-re-match-object
branch
2 times, most recently
from
f8e4617 to
0308a15
Compare
docs/changelog/1712.misc.rst
Outdated
| @@ -0,0 +1 @@ | |||
| Do not pass around regex match object in Replacer. - by :user:`jayvdb` | |||
There was a problem hiding this comment.
Only user-facing changes need changelog.
There was a problem hiding this comment.
great. But wont CI fail if this file doesnt exist?
There was a problem hiding this comment.
The check will fail but that's not mandatory for merge. You can add some naming of the title too to skip it I think 🤔
jayvdb
force-pushed
the
dont-pass-around-re-match-object
branch
from
0308a15 to
bdd4dac
Compare
Removes dead code and keep the match object within
Replacer._replace_match, adding explicit args to the other private methods ofReplacerso they are clearer.Related to #1711
Contribution checklist:
(also see CONTRIBUTING.rst for details)
in message body
<issue number>.<type>.rstfor example (588.bugfix.rst)<type>is must be one ofbugfix,feature,deprecation,breaking,doc,misc<your username>"superuser."CONTRIBUTORS(preserving alphabetical order)