Skip to content

PYTHONPATH leaks into "envreport" #2528

Closed
@f3flight

Description

@f3flight

Pretty trivial bug.
Even though tox discards PYTHONPATH for pip install, it does not discard it for pip freeze, causing garbage output if PYTHONPATH has any extra packages (i.e. "pip freeze" will see packages from PYTHONPATH, which it should not do).

https://github.com/tox-dev/tox/blob/3.27.0/src/tox/venv.py#L843

Fix is trivial - fetch env and apply ensure_pip_os_environ_ok the same way it is done for pip install, pass env to pcall. I will make a PR.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bug:normalaffects many people or has quite an impact

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions