Fix approval not shwoing up

Author: jmgasper

src/apps/review/src/lib/components/ChallengeDetailsContent/TabContentApproval.tsx

@@ -16,58 +16,6 @@ import {
 } from '../../../config/index.config'
 import { ChallengeDetailContext } from '../../contexts'
 
-const normalizeAlphaLowerCase = (value?: string): string | undefined => {
-    if (typeof value !== 'string') {
-        return undefined
-    }
-
-    const trimmed = value.trim()
-    return trimmed
-        ? trimmed
-            .toLowerCase()
-            .replace(/[^a-z]/g, '')
-        : undefined
-}
-
-const getSubmissionScore = (submission: SubmissionInfo): number => {
-    const scores: number[] = []
-
-    if (typeof submission.aggregateScore === 'number' && Number.isFinite(submission.aggregateScore)) {
-        scores.push(submission.aggregateScore)
-    }
-
-    if (typeof submission.review?.finalScore === 'number' && Number.isFinite(submission.review.finalScore)) {
-        scores.push(submission.review.finalScore)
-    }
-
-    if (Array.isArray(submission.reviews)) {
-        submission.reviews.forEach(reviewResult => {
-            const score = reviewResult?.score
-            if (typeof score === 'number' && Number.isFinite(score)) {
-                scores.push(score)
-            }
-        })
-    }
-
-    return scores.length
-        ? Math.max(...scores)
-        : Number.NEGATIVE_INFINITY
-}
-
-const getSubmissionTimestamp = (submission: SubmissionInfo): number => {
-    const submittedDate: SubmissionInfo['submittedDate'] = submission.submittedDate
-    if (submittedDate instanceof Date) {
-        return submittedDate.getTime()
-    }
-
-    if (typeof submittedDate === 'string') {
-        const parsed = Date.parse(submittedDate)
-        return Number.isFinite(parsed) ? parsed : Number.NEGATIVE_INFINITY
-    }
-
-    return Number.NEGATIVE_INFINITY
-}
-
 interface Props {
     reviews: SubmissionInfo[]
     submitterReviews: SubmissionInfo[]
@@ -97,43 +45,18 @@ export const TabContentApproval: FC<Props> = (props: Props) => {
     )
     const approvalRows: SubmissionInfo[] = useMemo(
         () => {
-            const inPhase = rawRows.filter(r => (r.review?.phaseId ? approvalPhaseIds.has(r.review.phaseId) : false))
-            if (!inPhase.length) {
-                return []
-            }
-
-            const reviewTypeRows = inPhase.filter(row => normalizeAlphaLowerCase(row.reviewTypeId) === 'review')
-            if (!reviewTypeRows.length) {
+            if (!rawRows.length) {
                 return []
             }
 
-            const passingRows = reviewTypeRows.filter(row => row.isPassingReview === true)
-            if (!passingRows.length) {
-                return []
+            if (approvalPhaseIds.size === 0) {
+                return rawRows
             }
 
-            const bestRow = passingRows.reduce<SubmissionInfo | undefined>((best, current) => {
-                if (!best) {
-                    return current
-                }
-
-                const bestScore = getSubmissionScore(best)
-                const currentScore = getSubmissionScore(current)
-
-                if (currentScore > bestScore) {
-                    return current
-                }
-
-                if (currentScore === bestScore) {
-                    const currentTimestamp = getSubmissionTimestamp(current)
-                    const bestTimestamp = getSubmissionTimestamp(best)
-                    return currentTimestamp > bestTimestamp ? current : best
-                }
-
-                return best
-            }, undefined)
-
-            return bestRow ? [bestRow] : []
+            return rawRows.filter(row => {
+                const phaseId = row.review?.phaseId
+                return phaseId ? approvalPhaseIds.has(phaseId) : false
+            })
         },
         [rawRows, approvalPhaseIds],
     )