Skip to content
This repository was archived by the owner on Oct 2, 2023. It is now read-only.

Commit 29a1fad

Browse files
author
Grace Yim
committed
Expect iframe postback data to be a string from POST parameter toopher_iframe_data
1 parent 9b7878f commit 29a1fad

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

test/test_toopher_iframe.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ def _get_auth_request_postback_data_as_dict(self):
4444

4545
def _get_urlencoded_auth_request_postback_data(self, auth_request_data = None):
4646
data = auth_request_data if auth_request_data else self._get_auth_request_postback_data_as_dict()
47-
return {'toopher_iframe_data': urllib.urlencode(data)}
47+
return urllib.urlencode(data)
4848

4949
def _get_pairing_postback_data_as_dict(self):
5050
return {
@@ -62,7 +62,7 @@ def _get_pairing_postback_data_as_dict(self):
6262

6363
def _get_urlencoded_pairing_postback_data(self, pairing_data=None):
6464
data = pairing_data if pairing_data else self._get_pairing_postback_data_as_dict()
65-
return {'toopher_iframe_data': urllib.urlencode(data)}
65+
return urllib.urlencode(data)
6666

6767
def _get_user_postback_data_as_dict(self):
6868
return {
@@ -77,7 +77,7 @@ def _get_user_postback_data_as_dict(self):
7777

7878
def _get_urlencoded_user_postback_data(self, user_data=None):
7979
data = user_data if user_data else self._get_user_postback_data_as_dict()
80-
return {'toopher_iframe_data': urllib.urlencode(data)}
80+
return urllib.urlencode(data)
8181

8282
def test_process_postback_good_signature_returns_authentication_request(self):
8383
auth_data = self._get_auth_request_postback_data_as_dict()

toopher/toopher_iframe.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -55,8 +55,8 @@ def get_user_management_url(self, username, reset_email='', **kwargs):
5555

5656
return self._get_oauth_signed_url(self.base_uri + '/web/manage_user', params, ttl)
5757

58-
def process_postback(self, urlencoded_form_data, request_token='', **kwargs):
59-
toopher_data = self._urldecode_iframe_data(urlencoded_form_data)
58+
def process_postback(self, urlencoded_toopher_data, request_token='', **kwargs):
59+
toopher_data = self._urldecode_iframe_data(urlencoded_toopher_data)
6060

6161
if 'error_code' in toopher_data:
6262
error_message = toopher_data['error_message']
@@ -91,7 +91,7 @@ def is_authentication_granted(self, data, request_token='', **kwargs):
9191
return False
9292

9393
def _urldecode_iframe_data(self, data):
94-
data_dict = urlparse.parse_qs(data['toopher_iframe_data'])
94+
data_dict = urlparse.parse_qs(data)
9595
return dict((k,v[0]) for (k,v) in data_dict.items())
9696

9797
def _validate_data(self, data, request_token, kwargs):

0 commit comments

Comments
 (0)