Skip to content

build(build-system): Remove setuptools build dependency #493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

tjni
Copy link

@tjni tjni commented Aug 17, 2023

This was added in 3bc03fb to support pip install -e . but I noticed that (per python-poetry/poetry#34 (comment)), this is fixed in pip >= 21.3.

For context, I am working on this package in nixpkgs and investigating if setuptools is really needed as a build dependency.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@tjni
Copy link
Author

tjni commented Aug 17, 2023

I don't want to read and sign a CLA. Please feel free to do whatever you want with this minor code change.

@tony
Copy link
Member

tony commented Aug 19, 2023

Thanks for helping on the package on nixpkgs.

I'd offer to have the CLA explained, but since you refused, yet also have this PR, I'm at an impasse.

@tony
Copy link
Member

tony commented Aug 20, 2023

Released v0.22.2

@tjni tjni deleted the remove-setuptools branch August 20, 2023 16:07
@tjni
Copy link
Author

tjni commented Aug 21, 2023

Thank you for taking care of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants