Skip to content

aiac: add page #9807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Feb 3, 2023
Merged

aiac: add page #9807

merged 7 commits into from
Feb 3, 2023

Conversation

DevMan01
Copy link
Contributor

@DevMan01 DevMan01 commented Jan 25, 2023 •
edited
Loading

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented: v1.0.0

@github-actions github-actions bot added the new command Issues requesting creation of a new page or PRs adding a new page for a command. label Jan 25, 2023
@DevMan01 DevMan01 marked this pull request as ready for review January 25, 2023 07:10
blueskyson
blueskyson reviewed Jan 26, 2023
View reviewed changes
DevMan01 and others added 4 commits January 26, 2023 00:00
@DevMan01 @blueskyson
Update pages/osx/aiac.md
c4ebd95 
Updating per @blueskyson comment.

Co-authored-by: Jack Lin <[email protected]>
@DevMan01 @blueskyson
Update pages/osx/aiac.md
a3eecf4 
Updating per @blueskyson comment.

Co-authored-by: Jack Lin <[email protected]>
@DevMan01 @blueskyson
Update pages/osx/aiac.md
419fcdf 
Updating per @blueskyson comment.

Co-authored-by: Jack Lin <[email protected]>
@DevMan01 @blueskyson
Update pages/osx/aiac.md
a8639e7 
Updating per @blueskyson comment.

Co-authored-by: Jack Lin <[email protected]>
@DevMan01
Copy link
Contributor Author

Changes made, ready for further review / approval.

kbdharun
kbdharun approved these changes Jan 27, 2023
View reviewed changes
Copy link
Member

@kbdharun kbdharun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for your contribution.

@DevMan01 @kbdharun
Update pages/osx/aiac.md
e956f45 
Updating per @kbdharun's suggestion.

Co-authored-by: K.B.Dharun Krishna <[email protected]>
@DevMan01
Copy link
Contributor Author

@blueskyson - We good for approval?

mfrw
mfrw reviewed Feb 3, 2023
View reviewed changes
Copy link
Member

@mfrw mfrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohh wow .. TIL
@DevMan01 Thanks for your contribution.

@kbdharun kbdharun merged commit 766d4d7 into tldr-pages:main Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfrw mfrw mfrw left review comments

@kbdharun kbdharun kbdharun approved these changes

@blueskyson blueskyson blueskyson approved these changes

Assignees
No one assigned
Labels
new command Issues requesting creation of a new page or PRs adding a new page for a command.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DevMan01 @mfrw @kbdharun @blueskyson