-
Notifications
You must be signed in to change notification settings - Fork 61
Project updates #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi @larrybotha, awesome work. A quick FYI — last time I checked codesandbox contained a bug when using the $ shorthand for accessing observable values. See https://github.com/codesandbox/codesandbox-client/issues/2415. So you might run into issues when adding that template. Regarding TypeScript — When I wrote this lib, the Svelte team was still working on TypeScript support. If by now TS is supported I'd happily spent some time with the conversion. |
@tjinauyeung ok, great to know about the Codesandbox issue. There's a language server that's had a lot of work recently: https://github.com/sveltejs/language-tools. I'm not sure if it's ready yet, as I'm waiting for things to stabilise before I use it, and there's still a lot of activity. The TS task can be low priority until someone's brave enough to give it a bash in :P |
Notes on preparing a project for |
@tjinauyeung FYI the TypeScript LSP for Svelte has been deemed production-ready! sveltejs/svelte#4518 (comment) I don't use VSCode, so I'll have to see what support looks like for me, but I'm keen to give it a bash this weekend and will let you know if I have any reservations. |
@tjinauyeung I've added a Also, please add me as a contributor on NPM - I can then evaluate the full deployment process. EDIT: oh yes, regarding the new language server - seems to be working ok in Vim at least. Not quite as good as the TS experience, but at least nothing broken. Will probably be great in VSCode. |
@tjinauyeung I just tried to replicate the codesandox issue mentioned above and it appears that this has been resolved: https://codesandbox.io/s/issue-2415-ce3sj?file=/App.svelte |
@larrybotha, I've added you on NPM as well. @tiaanduplessis That's great news. I might move the examples in the docs to codesandbox in the future! |
@larrybotha if you haven't gotten to it, I'll proceed and add a Codesandbox template in bug template to encourage repros of issues? |
@tiaanduplessis excellent, go ahead :) |
@tjinauyeung thanks for adding me to NPM. Took a quick look at Github actions as an alternative to Travis, but only collaborators with admin access can configure repo secrets. If you add |
Uh oh!
There was an error while loading. Please reload this page.
A list of collaborative / project update to
svelte-forms-lib
which will make contributing, publishing, and fixing issues easier. Feel free to submit a PR for any of the following:semantic-release
for automatic versioning based on commit messagescommitizen
for a commit convention thatsemantic-release
can use to determine version numbers for releases.prettierrc.js
for consistent formatting for all contributorshusky
pre-push hook to automate formatting for contributors not using prettiersvelte-forms-lib
codesandbox template in bug template to encourage SSCCE repros of issuesThe text was updated successfully, but these errors were encountered: