Skip to content

Fix typos #4364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix typos #4364

wants to merge 1 commit into from

Conversation

deining
Copy link

@deining deining commented Jul 25, 2024

This PR fixes various typos I spotted in the project.

@dkegel-fastly
Copy link
Contributor

Changes should be based on dev, not release.

That said, I took the liberty of improving golangci/misspell to handle (some of?) those typos, created a PR for that, and then created #4387 to use it to fix (most of?) the typos this PR fixes.

So probably want to just close this PR and maybe have another look when 4387 lands...?

@dkegel-fastly
Copy link
Contributor

That PR has landed, and #4406 will mop up a few it missed.

Closing in favor of those efforts.
Feel free to open a new PR that adds entries to spellfix.csv and includes the results of 'make spellfix'.

Thanks for pointing out the problems!

@deining deining mentioned this pull request Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants