Skip to content

Add docker image and dockerized dev tools #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
May 11, 2021

Conversation

samizdam
Copy link
Member

@samizdam samizdam commented Jul 16, 2019

Hi guys!

I'm don't have all stuff for run php projects locally. In my mind it be helpful for contributors with docker.

@anwinged anwinged self-requested a review July 17, 2019 07:54
Copy link
Member

@dmitrivereshchagin dmitrivereshchagin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think for most cases it's not practical to add unified development
environment to a library project. Code in a library is supposed to work
with several versions of PHP, dependencies, tools, etc. For this reason
we usually don't commit lock file in a library. I believe we should do
the same to our tools (for example we use PHP version constraint in
composer.json).

I find proposed tooling a little bit cumbersome for such a small project
which is not actively developed. As a compromise I would suggest to put
the following script in the root of the project under the name
composer and make it executable

#!/bin/sh -
exec docker run --rm -u "$(id -u):$(id -g)" -v "$PWD:/app" \
    -v composer-home:/tmp composer:1.8 composer "$@"

This script allows to perform most of the usual tasks possibly except of
code coverage reporting (depends on the PHP version).

@samizdam samizdam force-pushed the add-docker-image-and-dockerized-dev-tools branch 4 times, most recently from 31b46d9 to c017361 Compare May 11, 2021 16:27
@samizdam samizdam force-pushed the add-docker-image-and-dockerized-dev-tools branch from c017361 to e0e0945 Compare May 11, 2021 16:27
@samizdam samizdam merged commit 2c7a3d5 into master May 11, 2021
@samizdam samizdam deleted the add-docker-image-and-dockerized-dev-tools branch May 12, 2021 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants