Skip to content

Rename outline.type option "legacy" to "full" #3715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

yutannihilation
Copy link
Member

(Followup of #3708)

I originally named this option as "legacy" to discourage the usage in the hope of deprecating and removing this option eventually. But, this might be needed a bit longer than expected to keep the backward-compatibility of geom_density(). This PR

  • renames "legacy" to "full",
  • removes a warning, and
  • describes about geom_density() in the NEWS

Copy link
Member

@thomasp85 thomasp85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yutannihilation yutannihilation merged commit 029055c into tidyverse:v3.3.0-rc Jan 9, 2020
@yutannihilation yutannihilation deleted the fix/rename-outline.type-legacy-to-full branch January 9, 2020 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants