Synchronise lifecycle management #6733
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teunbrand
commented
Nov 6, 2025
R/utilities.R
Outdated
Comment on lines
790
to
792
| defunct <- "3.0.0" | ||
| full <- "3.4.0" | ||
| soft <- packageVersion("ggplot2") |
Collaborator
Author
There was a problem hiding this comment.
Just increment versions here if advancing the lifecycle.
thomasp85
approved these changes
Nov 18, 2025
Member
thomasp85
left a comment
thomasp85
left a comment
There was a problem hiding this comment.
The escalate argument is useful for when you want to, well, escalate a deprecation. It would be nice if deescalation was possible as well, e.g. keep something on soft even though we move the marker beyond that version threshold
Collaborator
Author
I agree that this would be nice to have, but doing it should be discouraged. I've added an option to postpone a cycle. |
Merge branch 'main' into lifecycle_manager # Conflicts: # R/aes.R
Collaborator
Author
|
Found a few cases of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix #6731.
It replaces the
deprecate_warn0()anddeprecate_soft0()internal functions with a new function:deprecate().If we want to advance the lifecycle of deprecated functions, we just need to edit the versions in
deprecate()instead of finding an replacing functions all over the place. There is also an option to escalate a deprecation to defunct or warning ahead of the cycle.